Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Test-Differences CPAN distribution.

Report information
The Basics
Id: 68216
Status: rejected
Priority: 0/
Queue: Test-Differences
People
Owner: Nobody in particular
Requestors: Support [...] RoxSoft.co.uk
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 0.61
Fixed in: (no value)

History Show all quoted text
  Sun May 15 16:38:20 2011 Support [...] RoxSoft.co.uk - Ticket created
Subject: Make '' and undef not equal - Breaks testing for Capture::Tiny
The attached patch fixes the problem with the Capture::Tiny tests whilst still allowing T::D to pass it's own tests
Subject: td.patch
--- lib/Test/Differences.pm 2011-05-15 21:28:23.000000000 +0100 +++ lib/Test/Differences.pm 2011-05-15 21:29:13.000000000 +0100 @@ -362,6 +362,8 @@ my $type = shift; local $_ = shift if @_; + ref or my $pbp_p114 = _quote_str( $_ ); + return [ split /^/m, _quote_str($_) ] unless ref; croak "Can't flatten $_" unless $type;
  Fri May 20 11:40:40 2011 dagolden [...] cpan.org - Correspondence added
On Sun May 15 16:38:20 2011, PJFL wrote: Show quoted text
> The attached patch fixes the problem with the Capture::Tiny tests whilst > still allowing T::D to pass it's own tests
Is the patch incomplete? It looks like $pbp_p114 is never used. -- David
  Fri May 20 11:40:42 2011 The RT System itself - Status changed from 'new' to 'open'
  Fri May 20 11:50:19 2011 Support [...] RoxSoft.co.uk - Correspondence added
The patch is complete. You are correct the variable is not used. It does allow Capture::Tiny to pass it's tests without breaking any of T::Ds tests. The patch could be applied and a new version shipped but really the _flatten subroutine needs to be rewritten so that it does not do local $_ = .... which combined with the recently added _quote_str subroutine seems to causing the problem
  Mon May 23 16:41:44 2011 Support [...] RoxSoft.co.uk - Correspondence added
Heisenbug. I can no longer reproduce this on any of my systems. Capture::Tiny is passing all tests again but without the patch being installed to T::D
  Wed Jun 25 17:20:22 2014 dcantrell [...] cpan.org - Correspondence added
On Mon May 23 16:41:44 2011, PJFL wrote: Show quoted text
> Heisenbug. I can no longer reproduce this on any of my systems. > Capture::Tiny is passing all tests again but without the patch being > installed to T::D
Marking this as 'rejected' because there's no "can't reproduce". If it ever comes back please open a new ticket, preferably with a patch and a test that fails against the current release and passes when the patch is applied.
  Wed Jun 25 17:20:25 2014 dcantrell [...] cpan.org - Status changed from 'open' to 'rejected'