Bug #68213 for ExtUtils-PkgConfig: Handle empty minor version

Sun May 15 13:16:51 2011 Fedora [...] FamilleCollet.com - Ticket created

Subject:	issue with GTK_MOZ_EMBED_CHECK_VERSION
Date:	Sun, 15 May 2011 19:16:42 +0200
To:	Bugs in Gtk2-MozEmbed via RT <bug-Gtk2-MozEmbed [...] rt.cpan.org>
From:	Remi Collet <Fedora [...] FamilleCollet.com>

First, I must apologize to have not report this "old" bug previously. I don't find any definition for this macro in include from xulrunner sdk. Do during build: [ CC xs/GtkMozEmbed.c ] xs/GtkMozEmbed.xs: In function 'XS_Gtk2__MozEmbed_new': xs/GtkMozEmbed.xs:291:42: error: missing expression between '(' and ')' make: *** [xs/GtkMozEmbed.o] Error 1 Trivial attached patch fix the build. I don't know if an old test for 1.7.3 still useful ?

Message body is not shown because sender requested not to inline it.

Mon May 16 14:16:41 2011 kaffeetisch [...] gmx.de - Correspondence added

Subject:	Re: [rt.cpan.org #68213] issue with GTK_MOZ_EMBED_CHECK_VERSION
Date:	Mon, 16 May 2011 20:16:29 +0200
To:	bug-Gtk2-MozEmbed [...] rt.cpan.org
From:	Torsten Schoenfeld <kaffeetisch [...] gmx.de>

On 15.05.2011 19:16, Remi Collet via RT wrote: Show quoted text

> I don't find any definition for this macro in include from xulrunner sdk. > > Do during build: > [ CC xs/GtkMozEmbed.c ] > xs/GtkMozEmbed.xs: In function 'XS_Gtk2__MozEmbed_new': > xs/GtkMozEmbed.xs:291:42: error: missing expression between '(' and ')' > make: *** [xs/GtkMozEmbed.o] Error 1

Hmm, GTK_MOZ_EMBED_CHECK_VERSION should actually be defined in build/gtkmozembed2perl-version.h, which should be generated by the ExtUtils::PkgConfig->write_version_macros call in Makefile.PL. Does this not happen for you?

Mon May 16 14:16:42 2011 The RT System itself - Status changed from 'new' to 'open'

Mon May 16 14:44:12 2011 Fedora [...] FamilleCollet.com - Correspondence added

Subject:	Re: [rt.cpan.org #68213] issue with GTK_MOZ_EMBED_CHECK_VERSION
Date:	Mon, 16 May 2011 20:44:01 +0200
To:	bug-Gtk2-MozEmbed [...] rt.cpan.org
From:	Remi Collet <Fedora [...] FamilleCollet.com>

Le 16/05/2011 20:16, Torsten Schoenfeld via RT a écrit : Show quoted text

> Hmm, GTK_MOZ_EMBED_CHECK_VERSION should actually be defined in > build/gtkmozembed2perl-version.h, which should be generated by the > ExtUtils::PkgConfig->write_version_macros call in Makefile.PL. Does > this not happen for you?

Yes, but $ cat gtkmozembed2perl-version.h #define GTK_MOZ_EMBED_MAJOR_VERSION (2) #define GTK_MOZ_EMBED_MINOR_VERSION () #define GTK_MOZ_EMBED_MICRO_VERSION (0) #define GTK_MOZ_EMBED_CHECK_VERSION(major,minor,micro) \ (GTK_MOZ_EMBED_MAJOR_VERSION > (major) || \ (GTK_MOZ_EMBED_MAJOR_VERSION == (major) && GTK_MOZ_EMBED_MINOR_VERSION Show quoted text

> (minor)) || \

(GTK_MOZ_EMBED_MAJOR_VERSION == (major) && GTK_MOZ_EMBED_MINOR_VERSION == (minor) && GTK_MOZ_EMBED_MICRO_VERSION >= (micro))) This issue is that MINOR is empty... Seems it's probaly an issue with ExtUtils::PkgConfig which doesn't handle this case (I will fill a bug) In create_version_macros, we have, $modversion[2] = 0 unless defined $modversion[2]; We probably need the same condition for $modversion[1] But it's probably usefull to fix this on Gtk2-Mozembed and not to rely on a specific ExtUtils::PkgConfig version

Mon May 16 14:50:48 2011 kaffeetisch [...] gmx.de - Subject changed from 'issue with GTK_MOZ_EMBED_CHECK_VERSION' to 'Handle empty minor version'

Mon May 16 14:50:48 2011 kaffeetisch [...] gmx.de - Queue changed from Gtk2-MozEmbed to ExtUtils-PkgConfig

Mon May 16 14:52:40 2011 kaffeetisch [...] gmx.de - Correspondence added

On Mon May 16 14:44:12 2011, Fedora@FamilleCollet.com wrote: Show quoted text

> Yes, but > > #define GTK_MOZ_EMBED_MINOR_VERSION ()

Ah, I see. Show quoted text

> Seems it's probaly an issue with ExtUtils::PkgConfig which doesn't > handle this case (I will fill a bug)

Yes. I moved this bug over to EU::PkgConfig's queue. Show quoted text

> In create_version_macros, we have, > $modversion[2] = 0 unless defined $modversion[2]; > > We probably need the same condition for $modversion[1]

Sounds likely. Show quoted text

> But it's probably usefull to fix this on Gtk2-Mozembed and not to rely > on a specific ExtUtils::PkgConfig version

No, let's fix the problem where it's caused.

Sat Apr 21 13:38:21 2012 kaffeetisch [...] gmx.de - Correspondence added

This is now fixed in git master: <http://git.gnome.org/browse/perl-ExtUtils-PkgConfig/commit/?id=046f0bd582e44283b0b76d3af5d43e8e2089bd36>.

Sat Apr 21 13:38:22 2012 kaffeetisch [...] gmx.de - Status changed from 'open' to 'resolved'