Skip Menu |

This queue is for tickets about the Memoize-Memcached CPAN distribution.

Report information
The Basics
Id: 68170
Status: resolved
Worked: 10 min
Priority: 0/
Queue: Memoize-Memcached

People
Owner: TCOHEN [...] cpan.org
Requestors: SILASMONK [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.03
Fixed in: 0.04



Subject: UNIVERSAL->import is getting deprecated with Perl 5.12.0
Proposed patch attached
Subject: universal.patch
Author: Nicholas Bamber <nicholas@periapt.co.uk> Subject: UNIVERSAL::import deprecated in perl 5.1 Last-Update: 2011-05-13 Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=614868 --- a/lib/Memoize/Memcached.pm +++ b/lib/Memoize/Memcached.pm @@ -3,7 +3,6 @@ use strict; use warnings; -use UNIVERSAL qw( isa ); use Carp qw( carp croak ); use Memoize qw( unmemoize ); use Cache::Memcached; @@ -49,7 +48,7 @@ my $memcached_args = delete $args{memcached} || {}; croak "Invalid memcached argument (expected a hash)" - unless isa($memcached_args, 'HASH'); + unless ref $memcached_args eq 'HASH'; _memcached_setup( %{$memcached_args}, @@ -138,7 +137,7 @@ next unless $arg eq 'memcached'; (undef, my $memcached_config) = splice @_, $idx, 2; croak "Invalid memcached config (expected a hash ref)" - unless isa($memcached_config, 'HASH'); + unless ref $memcached_config eq 'HASH'; %memcached_config = %{$memcached_config}; }
On Fri May 13 03:54:08 2011, SILASMONK wrote: Show quoted text
> Proposed patch attached
I've just created a Git repository for maintaining this codebase. The patch itself doesn't apply because it is not formatted for Git. I will anyway create a new patch in the Git repository that does the same.