Bug #68154 for Object-Accessor: Avoid use of deprecated exists($a[$i])

Thu May 12 15:09:18 2011 IKEGAMI [...] cpan.org - Ticket created

Subject:

Avoid use of deprecated exists($a[$i])

Object::Accessor uses L<perlfunc/exists> on array elements, and that has been deprecated since at least 5.12.0. I think avoiding it is very simple: --- a/lib/Object/Accessor.pm +++ b/lib/Object/Accessor.pm @@ -513,7 +513,7 @@ sub ___autoload { } ### need to check the value? - if( exists $self->{$method}->[ALLOW] ) { + if( defined $self->{$method}->[ALLOW] ) { ### double assignment due to 'used only once' warnings local $Params::Check::VERBOSE = 0; @@ -576,7 +576,7 @@ sub ___set { my $method = shift or return; ### you didn't give us a value to set! - exists $_[0] or return; + @_ or return; my $val = shift; ### if there's more arguments than $self, then

Thu May 12 16:00:25 2011 BINGOS [...] cpan.org - Correspondence added 30 min

Hi, Good catch! I've applied and released version 0.40 to CPAN. Many thanks.

Thu May 12 16:00:26 2011 The RT System itself - Status changed from 'new' to 'open'

Thu May 12 16:00:26 2011 BINGOS [...] cpan.org - Status changed from 'open' to 'resolved'

Thu May 12 16:00:27 2011 BINGOS [...] cpan.org - Given to BINGOS

Thu May 12 17:23:55 2011 IKEGAMI [...] cpan.org - Status changed from 'resolved' to 'open'

Thu May 12 17:24:46 2011 IKEGAMI [...] cpan.org - Correspondence added

I forgot to mention there's also a use of it t/05_Object-Accessor-callback.t, sorry.

Thu May 12 17:28:35 2011 IKEGAMI [...] cpan.org - Correspondence added

On Thu May 12 17:24:46 2011, ikegami wrote: Show quoted text

> I forgot to mention there's also a use of it > t/05_Object-Accessor-callback.t, sorry. >

Perhaps the fix is scalar @$val ? is( $val->[0], $SetVal, " Attempted to set $SetVal" ) - : ok( ! exists $val->[0], + : ok( ! @$val, " This was a GET request" );

Tue May 17 23:10:10 2011 IKEGAMI [...] cpan.org - Correspondence added

Thanks!

Tue May 17 23:10:11 2011 IKEGAMI [...] cpan.org - Status changed from 'open' to 'resolved'

Tue May 17 23:10:25 2011 IKEGAMI [...] cpan.org - Fixed in 0.42 added

Mon May 23 23:28:06 2011 IKEGAMI [...] cpan.org - Status changed from 'resolved' to 'open'

Mon May 23 23:28:06 2011 IKEGAMI [...] cpan.org - Fixed in 0.42 deleted

Mon May 23 23:30:47 2011 IKEGAMI [...] cpan.org - Correspondence added

I don't know how I missed it the first time around, but there is another deprecated use of exists on array elements. sub ls_allow { my $self = shift; my $key = shift or return; return exists $self->{$key}->[ALLOW] ? $self->{$key}->[ALLOW] : sub { 1 }; } (I'm working on adding a deprecated warning to exists($a[0]) and delete($a[0]).)

Wed Jan 23 09:00:56 2013 BINGOS [...] cpan.org - Correspondence added 10 min

All the issues raised by this ticket were resolved with 0.42 Many thanks.

Wed Jan 23 09:00:58 2013 BINGOS [...] cpan.org - Status changed from 'open' to 'resolved'