| Subject: | 3.53 test failures under perl 5.8.8 |
t/tmpdir.t fails installing CGI.pm 3.53:
Not enough arguments for mkdir at t/tmpdir.t line 11, near "mkdir;"
BEGIN not safe after errors--compilation aborted at t/tmpdir.t line 16.
# Looks like your test exited with 255 before it could output anything.
t/tmpdir.t ............... Dubious, test returned 255 (wstat 65280,
0xff00)
Problem is that test assumes mkdir will default FILENAME to $_, but
this isn't true in 5.8.5. It is in 5.12.3 (don't know exactly when
this feature was introduced.)
mkdir appears to only be used in this test, so it blocks installation
but doesn't appear to be a functional issue.
[CGI.pm-3.53-RhuHi1]$ find . -exec grep -H mkdir {} \;
./cgi_docs.html: > mkdir C:\Perl\lib\CGI
./t/tmpdir.t: ( -d ) || mkdir $_;
Patch:
--- tmpdir.t.bak 2011-01-23 22:20:29.000000000 -0500
+++ t/tmpdir.t 2011-04-30 09:01:25.000000000 -0400
@@ -6,11 +6,11 @@
BEGIN {
$testdir = "CGItest";
$testdir2 = "CGItest2";
for ($testdir, $testdir2) {
- ( -d ) || mkdir;
+ ( -d ) || mkdir $_;
( ! -w ) || chmod 0700, $_;
}
$CGITempFile::TMPDIRECTORY = $testdir;
$ENV{TMPDIR} = $testdir2;
}