Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the SVG-TT-Graph CPAN distribution.

Report information
The Basics
Id: 67834
Status: resolved
Priority: 0/
Queue: SVG-TT-Graph

People
Owner: Nobody in particular
Requestors: henrik.pauli [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.16
Fixed in: (no value)



Subject: dataPoint styles should be separate from fill styles
I saw on LLAP's site that dataPoints were styled with .dataPointNN, and this is the case in BarLine, but not in the other Line graphs. It's useful to be able to style them separately from fill, so I made a short and dirty patch to fix it in Line and TimeSeries.
Subject: dataPoint.patch
diff -Naurdp SVG-TT-Graph-0.16/lib/SVG/TT/Graph/Line.pm SVG-TT-Graph-0.16.dataPoint/lib/SVG/TT/Graph/Line.pm --- SVG-TT-Graph-0.16/lib/SVG/TT/Graph/Line.pm 2010-04-17 14:01:33.000000000 +0200 +++ SVG-TT-Graph-0.16.dataPoint/lib/SVG/TT/Graph/Line.pm 2011-04-29 16:45:44.903666067 +0200 @@ -808,7 +808,7 @@ __DATA__ [% FOREACH field = config.fields %] [% IF config.show_data_points %] <!-- datapoint shown --> - <circle cx="[% (dw * xcount) + x %]" cy="[% base_line - ((dataset.data.$field - min_scale_value) * divider) %]" r="2.5" class="fill[% line %]"/> + <circle cx="[% (dw * xcount) + x %]" cy="[% base_line - ((dataset.data.$field - min_scale_value) * divider) %]" r="2.5" class="dataPoint[% line %]"/> [% END %] [% IF config.show_data_values %] diff -Naurdp SVG-TT-Graph-0.16/lib/SVG/TT/Graph/TimeSeries.pm SVG-TT-Graph-0.16.dataPoint/lib/SVG/TT/Graph/TimeSeries.pm --- SVG-TT-Graph-0.16/lib/SVG/TT/Graph/TimeSeries.pm 2010-04-17 18:01:50.000000000 +0200 +++ SVG-TT-Graph-0.16.dataPoint/lib/SVG/TT/Graph/TimeSeries.pm 2011-04-29 16:49:28.844666469 +0200 @@ -1021,7 +1021,7 @@ __DATA__ [% IF ((pair.0 >= calc.min_timescale_value) && (pair.0 <= calc.max_timescale_value)) %] <g class="dataLabel[% line %]" [% IF config.rollover_values %] opacity="0" [% END %]> [% IF config.show_data_points %] - <circle cx="[% (dw * (pair.0 - calc.min_timescale_value)) + x %]" cy="[% base_line - (dh * (pair.1 - calc.min_scale_value)) %]" r="2.5" class="fill[% line %]" + <circle cx="[% (dw * (pair.0 - calc.min_timescale_value)) + x %]" cy="[% base_line - (dh * (pair.1 - calc.min_scale_value)) %]" r="2.5" class="dataPoint[% line %]" [% IF config.rollover_values %] onmouseover="evt.target.parentNode.setAttribute('opacity',1);" onmouseout="evt.target.parentNode.setAttribute('opacity',0);"
Hi Henrik, Thanks. I applied this patch to version 0.17. Florent