Bug #6782 for Test-Simple: Test::More not thread safe due to perl sort bug

[MSCHWERN - Wed Nov 24 16:46:48 2004]: Show quoted text
Since the core sort construct in question is "deeply, deeply, not thread-safe" (D. Mitchell) there are doubtless many ways to demonstrate a crash in any Perl module that uses it. The following test program demonstrates the bug for both Test-Simple-0.47 and Test-Simple-0.51. I tested with Perl version 5.8.4/5.8.5 (with ithreads) on both Linux and Windows. (If you want me to improve this test program for addition to the Test-Simple test suite, please let me know). #!/usr/bin/perl -w # Crash Test::More due to thread-hostile perl sort #30333 bug. use strict; use threads; # Passes with $nthreads = 1 and with eq_set(). # Passes with $nthreads = 2 and with eq_array(). # Fails with $nthreads = 2 and with eq_set(). my $nthreads = 2; use Test::More; plan tests => $nthreads; sub do_one_thread { my $kid = shift; my @list = ( 'x', 'yy', 'zzz', 'a', 'bb', 'ccc', 'aaaaa', 'z', 'hello', 's', 'thisisalongname', '1', '2', '3', 'abc', 'xyz', '1234567890', 'm', 'n', 'p' ); my @list2 = @list; warn "# kid $kid before eq_set\n"; sleep(1); for my $j (1..9999) { # With eq_set, either crashes or get: # "thread failed to start: panic: pp_iter at .../More.pm line 1127". # (Test-Simple-0.47) or line 1176 (Test-Simple-0.51). # Replace eq_set() with eq_array() and the panic goes away. eq_set(\@list, \@list2); # eq_array(\@list, \@list2); } warn "# kid $kid exit\n"; return 42; } my @kids = (); for my $i (1..$nthreads) { my $t = threads->new(\&do_one_thread, $i); warn "# parent $$: continue\n"; push(@kids, $t); } for my $t (@kids) { warn "# parent $$: waiting for join\n"; my $rc = $t->join(); cmp_ok( $rc, '==', 42, "threads exit status is $rc" ); }