Bug #67720 for Module-Extract-Namespaces: Unexpected behaviour with 5.14 style package declarations.

Sat Apr 23 19:24:48 2011 KENTNL [...] cpan.org - Ticket created

Subject:

Unexpected behaviour with 5.14 style package declarations.

Perl 5.14 introduces a new Package specification which currently renders confusing behaviour with this module.

"On failure it returns nothing, but you have to check with error to see if that is really an error or a file with no namespaces in it."

Sadly, this module produces neither nothing ( it returns a list with 1 item being 'undef' ) or produces an error in this scenario.

( Module::Extract::VERSION likely has a similar problem, but I haven't crossed that bridge yet )

I have a test in my github fork that replicates the situation I am seeing, and hopefully it is useful to you.

Thanks.

Sat Apr 23 19:27:14 2011 KENTNL [...] cpan.org - Correspondence added

Patches attached here:

https://github.com/briandfoy/module-extract-namespaces/pull/1

Sat Apr 23 19:27:15 2011 KENTNL [...] cpan.org - Status changed from 'new' to 'open'

Fri Apr 29 09:12:59 2011 bdfoy [...] cpan.org - Correspondence added

On Sat Apr 23 19:27:14 2011, KENTNL wrote: Show quoted text

> Patches attached here: > > https://github.com/briandfoy/module-extract-namespaces/pull/1

I've uploaded 0.14_01, which has a PPI fix.

Sat Apr 30 07:00:09 2011 KENTNL [...] cpan.org - Correspondence added

On 2011-04-30 01:12:59, BDFOY wrote:
Show quoted text

> On Sat Apr 23 19:27:14 2011, KENTNL wrote:

> > Patches attached here:
> >
> > https://github.com/briandfoy/module-extract-namespaces/pull/1

>
>
> I've uploaded 0.14_01, which has a PPI fix.

Thanks =).

The tests fail for me on 0.14_01 , due to it not being able to extract packages other than the first package declared, but this solution is in a good enough state to start using.

not ok 17 - Extracts right namespaces for NewPackageSyntax.pm
ok 18 - Corpus file [ corpus/None.pm ] exists

Show quoted text

#   Failed test 'Extracts right namespaces for NewPackageSyntax.pm'
#   at t/corpus.t line 32.
#     Structures begin differing at:
#          $got->[1] = Does not exist
#     $expected->[1] = 'Buster'

not ok 23 - Extracts right namespaces for NewPackageSyntax.pm

Show quoted text

#   Failed test 'Extracts right namespaces for NewPackageSyntax.pm'
#   at t/corpus.t line 54.
#     Structures begin differing at:
#          $got->[1] = Does not exist
#     $expected->[1] = ARRAY(0x1fafa80)

Sat Apr 30 16:42:53 2011 bdfoy [...] cpan.org - Correspondence added

I left out part of the PPI monkeypatching, which I've re-added for 0.14_02. We'll see how that goes.

Sat Apr 30 20:58:31 2011 KENTNL [...] cpan.org - Fixed in 0.14_02 added

Sat Apr 30 20:58:31 2011 KENTNL [...] cpan.org - Correspondence added

Tests passing for me with this release =). Thanks again.

Sun Jan 18 00:59:30 2015 bdfoy [...] cpan.org - Status changed from 'open' to 'resolved'

Sun Jan 18 00:59:31 2015 bdfoy [...] cpan.org - Taken