Skip Menu |

This queue is for tickets about the Module-CPANTS-Analyse CPAN distribution.

Report information
The Basics
Id: 67679
Status: resolved
Priority: 0/
Queue: Module-CPANTS-Analyse
People
Owner: Nobody in particular
Requestors: DOHERTY [...] cpan.org
dolmen [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Thu Apr 21 19:06:12 2011 DOHERTY [...] cpan.org - Ticket created
Subject: use_strict test doesn't allow alternatives
Using strict is obviously a good idea, but there are numerous acceptable alternatives. Moose is already handled, but common::sense, perl5i, Modern::Perl and others are all acceptable replacements for 'use strict'. Please recognize these in the use_strict test.
  Thu Apr 21 19:45:19 2011 doherty [...] cs.dal.ca - Correspondence added
Subject: Re: [rt.cpan.org #67679] AutoReply: use_strict test doesn't allow alternatives
Date: Thu, 21 Apr 2011 20:45:01 -0300
To: bug-Module-CPANTS-Analyse [...] rt.cpan.org
From: Mike Doherty <doherty [...] cs.dal.ca>
Here's a patch... I'll do a pull req on github too. -Mike

Message body is not shown because sender requested not to inline it.

  Thu Apr 21 19:45:21 2011 The RT System itself - Status changed from 'new' to 'open'
  Sun Oct 09 17:53:21 2011 perl [...] toby.ink - Correspondence added
On 2011-04-22T00:45:19+01:00, doherty@cs.dal.ca wrote: Show quoted text
> Here's a patch... I'll do a pull req on github too.
Correct me if I'm wrong, but say a distribution contains 3 modules. If two modules don't use strict, but the third one does this: use strict; use common::sense; use Modern::Perl; Then it will pass the use strict indicator.
  Thu Dec 15 06:08:26 2011 dolmen [...] cpan.org - Correspondence added
Le 2011-10-09 23:53:21, TOBYINK a écrit : Show quoted text
> Correct me if I'm wrong, but say a distribution contains 3 modules. If > two modules don't use strict, but the third one does this: > > use strict; > use common::sense; > use Modern::Perl; > > Then it will pass the use strict indicator.
@TOBYINK: This patch is for the cases were common::sense or Modern::Perl are used alone, without the 'use strict'. Those modules implies 'use strict', so the Kwalitee test should pass.
  Thu Dec 15 06:11:31 2011 dolmen [...] cpan.org - Correspondence added
Le 2011-04-22 01:45:19, doherty@cs.dal.ca a écrit : Show quoted text
> Here's a patch... I'll do a pull req on github too. > > -Mike
@DOHERTY Please add 'Moo' and 'Dancer' too. -- Olivier Mengué - http://perlresume.org/DOLMEN
  Thu Dec 15 06:12:35 2011 dolmen [...] cpan.org - Requestor DOLMEN added
  Sun Apr 01 07:57:54 2012 daxim [...] cpan.org - Correspondence added
fixed on github
  Sun Apr 01 07:57:56 2012 daxim [...] cpan.org - Status changed from 'open' to 'resolved'