Skip Menu |

This queue is for tickets about the Scalar-List-Utils CPAN distribution.

Report information
The Basics
Id: 67667
Status: open
Priority: 0/
Queue: Scalar-List-Utils

People
Owner: Nobody in particular
Requestors: TODDR [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.23
Fixed in: (no value)



Subject: Scalar::Util should install to site after 5.12
As of perl 5.12, site_lib comes first in the INC path by default. The p5p recommendation is for all dual life modules to install to site when installed of CPAN. I can dig up the mailing list thread if need be on this. Also if you want a patch for Makefile.PL, I'm happy to oblige.
On Thu Apr 21 12:40:27 2011, TODDR wrote: Show quoted text
> As of perl 5.12, site_lib comes first in the INC path by default. The > p5p recommendation is for all > dual life modules to install to site when installed of CPAN. I can dig > up the mailing list thread if > need be on this. > > Also if you want a patch for Makefile.PL, I'm happy to oblige.
I attached a patch that sets INSTALLDIRS to 'site' if the perl version is 5.11+. That seems to be the version that most duallife modules check for, so I hope that is the appropriate one. regards, Robert Sedlacek
Subject: install_to_site_post_5011.patch
diff --git a/Makefile.PL b/Makefile.PL index 40f9167..5068e34 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -28,7 +28,7 @@ WriteMakefile( ( $PERL_CORE ? () : ( - INSTALLDIRS => q[perl], + INSTALLDIRS => ($] < 5.011 ? q[perl] : q[site]), PREREQ_PM => {'Test::More' => 0,}, (eval { ExtUtils::MakeMaker->VERSION(6.31) } ? (LICENSE => 'perl') : ()), ( eval { ExtUtils::MakeMaker->VERSION(6.46) } ? (
On Sat Sep 22 17:30:21 2012, PHAYLON wrote: Show quoted text
> I attached a patch that sets INSTALLDIRS to 'site' if the perl version > is 5.11+. That seems to be the version that most duallife modules check > for, so I hope that is the appropriate one.
Looks good. Will include that in next version. -- Paul Evans
On 2012-09-27 10:24:26, PEVANS wrote: Show quoted text
> On Sat Sep 22 17:30:21 2012, PHAYLON wrote:
> > I attached a patch that sets INSTALLDIRS to 'site' if the perl version > > is 5.11+. That seems to be the version that most duallife modules check > > for, so I hope that is the appropriate one.
> > Looks good. Will include that in next version.
I'm making this same change for Module::Metadata.
On 2013-05-08 15:54:34, ETHER wrote: Show quoted text
> I'm making this same change for Module::Metadata.
..and reverted it again (MM was only cored in 5.14.)
This fix seem to have shipped to CPAN with 1.26 last year. Perhaps the ticket should be closed?