Bug #67664 for CGI-Application-Dispatch: Deprecation warning with Perl 5.14.0 RC1

Thu Apr 21 09:19:12 2011 RENEEB [...] cpan.org - Ticket created

Subject:

Deprecation warning with Perl 5.14.0 RC1

Hi, I just tested CGI::Application::Dispatch with the new Perl 5.14.0 RC1 and I get a deprecation warning for the use of qw() as parenthesis: Use of qw(...) as parentheses is deprecated at /home/entwicklung/.cpan/build/CGI-Application-Dispatch-2.18-em1omR/blib/lib/CGI/Application/Dispatch.pm line 792. The new deprecations are described in http://search.cpan.org/~jesse/perl-5.14.0-RC1/pod/perldelta.pod#Deprecations - Renée

Thu Apr 21 09:32:32 2011 mark [...] summersault.com - Correspondence added

Subject:	Re: [rt.cpan.org #67664] Deprecation warning with Perl 5.14.0 RC1
Date:	Thu, 21 Apr 2011 09:32:23 -0400
To:	bug-CGI-Application-Dispatch [...] rt.cpan.org
From:	Mark Stosberg <mark [...] summersault.com>

Thanks for the report. We'll fix it. Mark

Thu Apr 21 09:32:34 2011 The RT System itself - Status changed from 'new' to 'open'

Thu Oct 13 15:58:35 2011 danrumney [...] warpmail.net - Correspondence added

From:

danrumney [...] warpmail.net

Attached is a patch based on v3.0.7

Subject:

Dispatch.pm.patched

Download Dispatch.pm.patched
application/octet-stream 40.8k

Message body not shown because it is not plain text.

Sat Nov 26 11:51:39 2011 SILASMONK [...] cpan.org - Correspondence added

RT-Send-CC:

mark [...] summersault.com, danrumney [...] warpmail.net

On Thu Oct 13 15:58:35 2011, dancrumb wrote: Show quoted text

> Attached is a patch based on v3.0.7 >

I don't this patch fixes the problem. qw/.../ is just the same as qw(...). What is required is (qw(...)) though this is only needed where the extra brackets are part of statement syntax.

Sat Nov 26 13:26:49 2011 RENEEB [...] cpan.org - Correspondence added

Am Sa 26. Nov 2011, 11:51:39, SILASMONK schrieb: Show quoted text

> On Thu Oct 13 15:58:35 2011, dancrumb wrote:

> > Attached is a patch based on v3.0.7 > >

> > > I don't this patch fixes the problem. qw/.../ is just the same as > qw(...). What is required is (qw(...)) though this is only needed where > the extra brackets are part of statement syntax.

Correct. There is only one line in Dispatch.pm that has to be fixed. It's line 795 (version 3.07) that should read for my $var (qw(DEFAULT PREFIX ERROR_DOCUMENT)) { instead of for my $var qw(DEFAULT PREFIX ERROR_DOCUMENT) {

Sat Nov 26 14:47:11 2011 SILASMONK [...] cpan.org - Correspondence added

Here is that expressed as a patch. On Sat Nov 26 13:26:49 2011, RENEEB wrote: Show quoted text

> Am Sa 26. Nov 2011, 11:51:39, SILASMONK schrieb:

> > On Thu Oct 13 15:58:35 2011, dancrumb wrote:

> > > Attached is a patch based on v3.0.7 > > >

> > > > > > I don't this patch fixes the problem. qw/.../ is just the same as > > qw(...). What is required is (qw(...)) though this is only needed

where Show quoted text

> > the extra brackets are part of statement syntax.

> > Correct. There is only one line in Dispatch.pm that has to be fixed. > It's line 795 (version 3.07) that should read > > for my $var (qw(DEFAULT PREFIX ERROR_DOCUMENT)) { > > instead of > > for my $var qw(DEFAULT PREFIX ERROR_DOCUMENT) { >

Subject:

deprecation.patch

Author: Dan Rumney <reneeb@cpan.org> Subject: 5.14 deprecation Last-Update: 2011-11-26 Bug: http://rt.cpan.org/Tickt/Display.html?id=67664 --- a/lib/CGI/Application/Dispatch.pm +++ b/lib/CGI/Application/Dispatch.pm @@ -792,7 +792,7 @@ # setup our args to dispatch() my %args; my $config_args = $r->dir_config(); - for my $var qw(DEFAULT PREFIX ERROR_DOCUMENT) { + for my $var (qw(DEFAULT PREFIX ERROR_DOCUMENT)) { my $dir_var = "CGIAPP_DISPATCH_$var"; $args{lc($var)} = $config_args->{$dir_var} if($config_args->{$dir_var});

Mon Nov 28 11:24:49 2011 MARKSTOS [...] cpan.org - Taken

Mon Nov 28 11:25:20 2011 MARKSTOS [...] cpan.org - Correspondence added

Thanks for the follow-up. Mark

Sat Sep 01 00:03:55 2012 MARKSTOS [...] cpan.org - Correspondence added

I'm sorry this took forever to get released. I'm taking care of that now.

Sat Sep 01 00:03:55 2012 MARKSTOS [...] cpan.org - Status changed from 'open' to 'resolved'