Bug #6758 for Test-Unit: Constructing debug message in Test::Unit::Assertion::CodeRef takes too mach time

Fri Jun 25 10:17:00 2004 Guest - Ticket created

Subject:

Constructing debug message in Test::Unit::Assertion::CodeRef takes too mach time

debug(" asserting [$self]"...) takes to mach time to construct parameter string and if debbuging is not enabled this message is totally in vain.

Tue Sep 21 05:42:40 2004 MARKOV [...] cpan.org - Correspondence added

[guest - Fri Jun 25 10:17:00 2004]: Show quoted text

> debug(" asserting [$self]"...) takes to mach time to construct > parameter string and if debbuging is not enabled this message is > totally in vain.

Of course: when the object is a message, stringification will fill-in the whole message. So, you probably can better do debug(" asserting [".$self->subject."]");

Mon Jun 27 16:42:42 2011 mca1001 [...] users.sourceforge.net - Taken

Mon Jun 27 17:01:43 2011 mca1001 [...] users.sourceforge.net - Correspondence added

On Fri Jun 25 10:17:00 2004, guest wrote: Show quoted text

> debug(" asserting [$self]"...) takes to mach time to construct > parameter string and if debbuging is not enabled this message is > totally in vain.

Hi aa29@, Thank you for the report and I'm sorry it has taken a long time to act on it. I have fixed this in http://perlunit.git.sourceforge.net/git/gitweb.cgi?p=perlunit/perlunit;a=commit;h=0af160c2ac42c3da16e6733b1da8f4772959b40c which I will release shortly. The speedup for a set of tests like the distribution self-tests is about 50% of the CPU time. On Tue Sep 21 05:42:40 2004, MARKOV wrote: Show quoted text

> Of course: when the object is a message, stringification will > fill-in the whole message. So, you probably can better do > > debug(" asserting [".$self->subject."]");

Hi MARKOV, The debug output is rather noisy anyway, but it's mostly for internal use. The magical to_string methods will still be slow, but are no longer called internally. I wasn't sure what you wanted to change by using a ->subject method instead of the existing (implicit) ->to_string so I didn't use that idea. Will mark the ticket resolved, but please reply if you are still interested in some related change. Thanks, -- Matthew

Mon Jun 27 17:01:44 2011 The RT System itself - Status changed from 'new' to 'open'

Mon Jun 27 17:01:44 2011 mca1001 [...] users.sourceforge.net - Status changed from 'open' to 'resolved'

Tue Jun 28 13:53:17 2011 aa29 [...] mail.ru - Correspondence added

Subject:	Re: [rt.cpan.org #6758] Resolved: Constructing debug message in Test::Unit::Assertion::CodeRef takes too mach time
Date:	Tue, 28 Jun 2011 13:06:55 +0400
To:	bug-Test-Unit [...] rt.cpan.org
From:	Andrey Alakozov <aa29 [...] mail.ru>

Thanks! -- Andrey

Tue Jun 28 13:53:19 2011 The RT System itself - Status changed from 'resolved' to 'open'