Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Dist-Zilla CPAN distribution.

Report information
The Basics
Id: 67551
Status: resolved
Priority: 0/
Queue: Dist-Zilla

People
Owner: Nobody in particular
Requestors: dolmen [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 4.200004
Fixed in: (no value)



Subject: 'setup' creates config.ini with locale encoding (portability issue)
This is on Win32. My name is "Olivier Mengué", which is non-pure ASCII. When running "dzil setup", the generated "%APPDATA%\.dzil\config.ini" has been written using code page "cp850" which is the code page of the console. This makes the config.ini system-locale-dependent. When creating a new distribution after, the dist.ini is also created in code page "cp850": the initial problem is propagated. This makes the dist.ini system-locale-dependent and so is a portability problem when sharing the project with other operating systems. Instead, config.ini (and any D::Z config file) I/O should be done with an explicit encoding (UTF-8). How to reproduce: C:\Users\Dolmen\Documents\Code\Perl\Patch-Zilla>dzil setup What's your name? Olivier Mengué What's your email address? dolmen@cpan.org Who, by default, holds the copyright on your code? [Olivier Mengué]: What license will you use by default (Perl_5, BSD, etc.)? [Perl_5]: Do you want to enter your PAUSE account details? [y/N]: y What is your PAUSE id? [DOLMEN]: What is your PAUSE password? xxxxxxxxxxxxxxxxxx config.ini file created! -- Olivier Mengué - http://search.cpan.org/~dolmen/ http://github.com/dolmen/
Dist::Zilla and its associated toolchain still has plenty of encoding problems which I hope to solve this year. This specific problem, related to the encoding of the setup command, appears to have been addressed in 2011 by 0f3d4926. -- rjbs
Le 2013-07-23 20:08:29, RJBS a écrit : Show quoted text
> Dist::Zilla and its associated toolchain still has plenty of encoding > problems which I hope to solve this year. > > This specific problem, related to the encoding of the setup command, > appears to have been addressed in 2011 by 0f3d4926.
0f3d4926 only solves the issue if the locale encoding is UTF-8. This fixes nothing on Win32: the config.ini will be created in UTF-8 but read as if it was latin1. So I'm reopening the bug. I have some work in progress to really fix the issue by allowing to specify encoding for input in Config::INI. But if I remember well, Config::MVP had to be fixed too (I may have a WIP for that too). https://github.com/dolmen/p5-Config-INI/tree/feature/encoding -- Olivier Mengué - http://perlresume.org/DOLMEN
Should be fixed by DZ 5. Please open a GH issue if not. Thanks so much for your patience! http://rjbs.manxome.org/rubric/entry/2021 -- rjbs