Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Dist-Zilla CPAN distribution.

Report information
The Basics
Id: 67354
Status: rejected
Priority: 0/
Queue: Dist-Zilla
People
Owner: Nobody in particular
Requestors: geistteufel [...] yahoo.fr
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 4.200004
Fixed in: (no value)

History Show all quoted text
  Sun Apr 10 06:22:39 2011 geistteufel [...] yahoo.fr - Ticket created
Subject: [PkgVersion] doesn't pass PerlCritic severity 3
The code is add before strict and warnings, so it fail with perlcritic. If I put strict and warnings before package, it fail too because with can't add code before package. Is they a way to add it after "use strict; use warnings" ?
  Tue Apr 19 23:49:54 2011 DOHERTY [...] cpan.org - Correspondence added
On Sun Apr 10 06:22:39 2011, Geistteufel wrote: Show quoted text
> The code is add before strict and warnings, so it fail with perlcritic. > If I put strict and warnings before package, it fail too because with > can't add code before package. > > Is they a way to add it after "use strict; use warnings" ?
You probably want to use OurPkgVersion.
  Tue Apr 19 23:49:55 2011 The RT System itself - Status changed from 'new' to 'open'
  Thu Apr 21 10:16:00 2011 CELOGEEK [...] cpan.org - Correspondence added
Le Mar 19 Avr 2011 23:49:54, DOHERTY a écrit : Show quoted text
> On Sun Apr 10 06:22:39 2011, Geistteufel wrote:
> > The code is add before strict and warnings, so it fail with perlcritic. > > If I put strict and warnings before package, it fail too because with > > can't add code before package. > > > > Is they a way to add it after "use strict; use warnings" ?
> > You probably want to use OurPkgVersion.
well, it s a good alternative. i m waiting the patch for perl critic. the thing is it s a bit more work, i need to add # VERSION everywhere.
  Mon Apr 25 11:09:38 2011 rjbs [...] cpan.org - Correspondence added
I don't think this is a bug. It needs to know where to add the version, and "immediately after package" is a pretty good place. I use Perl-Critic-Lax's policy to allow strict and warnings before package. OurPkgVersion is also an option. -- rjbs
  Mon Apr 25 11:09:39 2011 rjbs [...] cpan.org - Status changed from 'open' to 'rejected'