Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Test-CheckManifest CPAN distribution.

Report information
The Basics
Id: 67334
Status: resolved
Priority: 0/
Queue: Test-CheckManifest

People
Owner: Nobody in particular
Requestors: JWEIGEL [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.23
Fixed in: (no value)



Subject: Problem parsing MANIFEST when file name contains a space
If a file in the MANIFEST contains a space it is not parsed correctly and results in a test failure. I've attached a patch that fixes the regular expression to capture file names with spaces in the MANIFEST.
Subject: tcm.patch
diff -Nru Test-CheckManifest-1.23/lib/Test/CheckManifest.pm Test-CheckManifest-1.23-new/lib/Test/CheckManifest.pm --- Test-CheckManifest-1.23/lib/Test/CheckManifest.pm 2011-03-28 01:51:17.000000000 -0500 +++ Test-CheckManifest-1.23-new/lib/Test/CheckManifest.pm 2011-04-08 11:09:17.000000000 -0500 @@ -86,8 +86,8 @@ my @files; while( my $fh_line = <$fh> ){ - if( $fh_line =~ /^\s*([^\s#]\S*)/ and $fh_line !~ /^META\.yml/ ){ - push @files, $1; + if( $fh_line =~ /^\s*(?:'([^']+)'|([^\s#]\S*))/ and $fh_line !~ /^META\.yml/ ){ + push @files, $1 || $2; } } #my @files = grep{!/^\s*$/ and !/^META\.yml/}<$fh>;
Thanks for your report. This is fixed in version 1.24 that should be available on CPAN in a few hours. - Renée