Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 67273
Status: resolved
Priority: 0/
Queue: Perl-Critic
People
Owner: Nobody in particular
Requestors: EDAVIS [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 1.115
Fixed in: (no value)

History Show all quoted text
  Wed Apr 06 08:49:52 2011 EDAVIS [...] cpan.org - Ticket created
Subject: Another ProhibitUnusedCapture false positive
I think that ProhibitUnusedCapture doesn't understand ${1} on the RHS of a substitution, for example #!/usr/bin/perl # $Id: $ use warnings; use strict; use Carp qw(croak); our $VERSION = 1; $_ = 'bab'; s/b(a)b/${1}/sxm; print $_ or croak;
  Wed Apr 06 21:12:49 2011 wyant [...] cpan.org - Correspondence added
On Wed Apr 06 08:49:52 2011, EDAVIS wrote: Show quoted text
> I think that ProhibitUnusedCapture doesn't understand ${1} on the RHS of > a substitution, for example > > #!/usr/bin/perl > # $Id: $ > use warnings; > use strict; > use Carp qw(croak); > our $VERSION = 1; > > $_ = 'bab'; > s/b(a)b/${1}/sxm; > print $_ or croak;
I have good news and bad news. The bad news is that I can not duplicate this. The good news is that this looks like a PPIx::Regexp bug that was fixed in version 0.018, which went out 16-Feb-2011. What version of PPIx::Regexp are you running? If less than 0.018, can you upgrade, and does upgrading fix the problem?
  Wed Apr 06 21:12:50 2011 The RT System itself - Status changed from 'new' to 'open'
  Thu Apr 07 07:11:43 2011 EDAVIS [...] cpan.org - Correspondence added
I can confirm that this is buggy with PPIx::Regexp 0.014 and correct with PPIx::Regexp 0.020.
  Tue Apr 12 20:36:29 2011 wyant [...] cpan.org - Correspondence added
On Thu Apr 07 07:11:43 2011, EDAVIS wrote: Show quoted text
> I can confirm that this is buggy with PPIx::Regexp 0.014 and correct > with PPIx::Regexp 0.020.
I have bumped the required version of PPIx::Regexp to 0.019, since that is the version that understands the most about things like s/(a)/${1}/. Version 0.020 is out, but all it has above 0.019 is a tweak in the perl_version_introduced() logic, which Perl::Critic does not use (I think). This is SVN revision 4073.
  Tue Apr 12 20:36:31 2011 The RT System itself - System error
Sending the previous mail has failed. Please contact your admin, they can find more details in the logs.
  Tue Apr 12 20:36:31 2011 The RT System itself - System error
Sending the previous mail has failed. Please contact your admin, they can find more details in the logs.
  Wed Jul 20 14:16:02 2011 wyant [...] cpan.org - Status changed from 'open' to 'patched'
  Wed Jul 11 04:08:17 2012 thaljef [...] cpan.org - Correspondence added
Fixed and released in Perl-Critic-1.117. Thanks for reporting this. -- Jeffrey Thalhammer Imaginative Software Systems www.imaginative-software.com
  Wed Jul 11 04:08:18 2012 The RT System itself - Status changed from 'patched' to 'open'
  Wed Jul 11 04:08:18 2012 thaljef [...] cpan.org - Status changed from 'open' to 'resolved'