Skip Menu |

This queue is for tickets about the Dist-Zilla-Plugin-ReportVersions-Tiny CPAN distribution.

Maintainer(s)' notes

This module is deprecated!

This distribution has reached end-of-life now that better alternatives exist.

The recommended alternative is Dist::Zilla::Plugin::Test::ReportPrereqs.

Report information
The Basics
Id: 67127
Status: resolved
Priority: 0/
Queue: Dist-Zilla-Plugin-ReportVersions-Tiny

People
Owner: Nobody in particular
Requestors: APOCAL [...] cpan.org
KENTNL [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: 1.03
Fixed in: (no value)



Subject: Minor spelling+style tweaks
Hello, I was staring at a bugreport that had your module's output in it ( yay! ) but noticed a few errors and wanted to fix them :) 1. Spelling error in the text block output after the test. Line 83 in the code should say "solve your problem" not "solve you problem". 2. I was uncertain what version of this module was used to generate the test, and thought it would be helpful if you could report this. Attached is a patch which does this. Please let me know if you like what I did :) Thanks again! -- ~Apocalypse
Subject: dzp_tiny.patch
diff -urbd a/Tiny.pm b/Tiny.pm --- a/Tiny.pm 2011-03-31 15:52:54.000000000 -0700 +++ b/Tiny.pm 2011-03-31 15:57:21.000000000 -0700 @@ -23,6 +23,9 @@ my $v = "\n"; +# List our own version used to generate this +$v .= "Generated by {{$my_package}} v{{$my_version}}\n"; + eval { # no excuses! # report our Perl details my $want = {{ @@ -80,7 +83,7 @@ Thanks for using my code. I hope it works for you. If not, please try and include this output in the bug report. -That will help me reproduce the issue and solve you problem. +That will help me reproduce the issue and solve your problem. EOT @@ -127,7 +130,9 @@ sub generate_test_from_prereqs { my ($self) = @_; my $content = $self->fill_in_string($template, { - modules => $self->applicable_modules + modules => $self->applicable_modules, + my_version => __PACKAGE__->VERSION, + my_package => __PACKAGE__, }); return $content;
Subject: Re: [rt.cpan.org #67127] Minor spelling+style tweaks
Date: Thu, 7 Apr 2011 18:20:59 -0700
To: bug-Dist-Zilla-Plugin-ReportVersions-Tiny [...] rt.cpan.org
From: Daniel Pittman <daniel [...] rimspace.net>
On Thu, Mar 31, 2011 at 15:58, Apocalypse via RT <bug-Dist-Zilla-Plugin-ReportVersions-Tiny@rt.cpan.org> wrote: Show quoted text
>  I was staring at a bugreport that had your module's output in it ( yay! > ) but noticed a few errors and wanted to fix them :) > >  1. Spelling error in the text block output after the test. Line 83 in > the code should say "solve your problem" not "solve you problem". > >  2. I was uncertain what version of this module was used to generate the > test, and thought it would be helpful if you could report this. > >  Attached is a patch which does this. Please let me know if you like > what I did :)
Hey. I love the general idea, and think both are great. It is crunch time at work until the 13th, though, so I don't have much time to get a new release out. I didn't want to neglect this, and if I can I will try and roll out a new version ASAP, but until then please don't feel my silence is because your contribution was not valued. Thanks, Daniel -- ⎋ Puppet Labs Developer – http://puppetlabs.com ✉ Daniel Pittman <daniel@rimspace.net> ✆ Contact me via gtalk, email, or phone: +1 (503) 893-2285 ♲ Made with 100 percent post-consumer electrons

Hi Again Daniel.

I got bored yesterday and decided to work on a few bugs with ReportVersions::Tiny, including solving the version comparison bug ( https://github.com/kentfredric/Dist-Zilla-Plugin-ReportVersions-Tiny/commits/3-partcmp&nbsp;)&nbsp; and this one ( https://github.com/kentfredric/Dist-Zilla-Plugin-ReportVersions-Tiny/commits/fixes ) , and additionally have integrated rwstauners 'include' branch as well ( https://github.com/kentfredric/Dist-Zilla-Plugin-ReportVersions-Tiny/commits/include )

It works for me, but I'm not 100% with testing it yet to the point I'd be satisfied filing a pull request.

However, I've gotten stuck with your @BUNDLE being a bit out-dated and its bugging for me.

I see you're busy, and I'd glady see what I could do to the bundle to bring it back to working condition again to save you the effort =), just need a copy of the repo on github to start from.

I've sort of refactored some of the internals and Test internals too ( which rwstauner also suggested ) to make testing slightly easier, as well as eliminating Test::Exception in favour of a slighly lower dep weight and less XS dependent Test::Fatal

Total delta at present is https://github.com/kentfredric/Dist-Zilla-Plugin-ReportVersions-Tiny/compare/master...include

Anything I can do to make it easier for you, just feel free to let me know =)
 

 



 

Le 2012-03-18 01:32:26, KENTNL a écrit : Show quoted text
> Hi Again Daniel. > > I got bored yesterday and decided to work on a few bugs with > ReportVersions::Tiny,
The original repository is here: https://github.com/daniel-pittman/Dist-Zilla-Plugin-ReportVersions-Tiny
Le 2012-05-10 20:17:17, DOLMEN a écrit : Show quoted text
> Le 2012-03-18 01:32:26, KENTNL a écrit :
> > Hi Again Daniel. > > > > I got bored yesterday and decided to work on a few bugs with > > ReportVersions::Tiny,
> > The original repository is here: > https://github.com/daniel-pittman/Dist-Zilla-Plugin-ReportVersions-Tiny
Sorry KENTNL I had not seen you cleanly forked it. But the fact that your pull request is on your own repository instead of being pushed to Daniel is strange... -- Olivier Mengué - http://perlresume.org/DOLMEN
Show quoted text
> Sorry KENTNL I had not seen you cleanly forked it. > But the fact that your pull request is on your own repository instead of > being pushed to Daniel is strange... >
Lol, was just about to comment on that. =) Yeah, was asking for a git of his *BUNDLE* which is presently broken =). Though why I have filed a pull request against myself, I'll just have to blame github for that. Or narcissism. Not sure which, going blind from pulling against myself too often. Anyhow. New Pull request: https://github.com/daniel-pittman/Dist-Zilla-Plugin-ReportVersions-Tiny/pull/2
On 2012-05-11 06:27:17, KENTNL wrote: Show quoted text
> > Though why I have filed a pull request against myself, I'll just have > to blame github for that. Or narcissism. Not sure which, going blind > from pulling against myself too often.
Facepalm. -_- "I'm not 100% with testing it yet to the point I'd be satisfied filing a pull request" I think I pull-requested myself or something because I wasn't happy with pull requesting yet. Or something. Who knows. I probably shouldn't go this long without sleep. :D
I'm the new maintainer for this distribution. I've started to cherry-pick all your patches on my branch https://github.com/dolmen/p5-Dist-Zilla-Plugin-ReportVersions-Tiny/tree/master.kentfredric Tell me if that's ok to release as is. -- Olivier Mengué - http://perlresume.org/DOLMEN
At this stage I can only confirm, having rebased my branch myself, my branch and your branch appear to be the same.

As to whether or not its good to release, not sure, can't tell as not all the required Deps can be installed at present ( Perl::Critic is broken by the recent Perl::Tidy , causing a domino of failures )

If it works for you as expected, its probably release safe. You can always release a bug fix release later anyway =p.

And if you're really worried, you can -TRIAL it =).
Merged and released in 1.05 on July 18th 2012. -- Olivier Mengué - http://perlresume.org/DOLMEN