Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 67116
Status: resolved
Priority: 0/
Queue: Perl-Critic
People
Owner: Nobody in particular
Requestors: EDAVIS [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 1.114
Fixed in: 1.115
Attachments
crash_perlcritic
rt67116.pat

History Show all quoted text
  Thu Mar 31 10:25:38 2011 EDAVIS [...] cpan.org - Ticket created
Subject: Crash in RegularExpressions::ProhibitUnusedCapture
The attached Perl program crashes perlcritic: % cat crash_perlcritic $x !~ /()/; <<X , , , , , % perlcritic --single-policy RegularExpressions::ProhibitUnusedCapture crash_perlcritic Fatal error while critiquing "crash_perlcritic": Can't call method "uses_module" without a package or object reference at /usr/share/perl5/Perl/Critic/Policy/RegularExpressions/ProhibitUnusedCapture.pm line 573. Whitespace is significant, so please use the attachment. This test case is not a well-formed Perl program. I think perlcritic should not crash on any input, but if you disagree, I am able to provide a less minimal test case which is valid Perl code.
Subject: crash_perlcritic
Download crash_perlcritic
application/octet-stream 27b

Message body not shown because it is not plain text.

  Thu Mar 31 10:26:26 2011 EDAVIS [...] cpan.org - Correspondence added
To add, I am using Perl::Critic 1.114 on Fedora 14 x86_64, with PPI 1.25.
  Thu Mar 31 10:26:27 2011 EDAVIS [...] cpan.org - Status changed from 'new' to 'open'
  Thu Mar 31 10:47:18 2011 wyant [...] cpan.org - Correspondence added
On Thu Mar 31 10:26:26 2011, EDAVIS wrote: Show quoted text
> To add, I am using Perl::Critic 1.114 on Fedora 14 x86_64, with PPI 1.25.
Works in Perl::Critic 1.113, so it looks like there's a regression. My apologies. I assume you mean PPI 1.215? And for my curiosity, what does /()/ actually do? Tom
  Thu Mar 31 11:31:52 2011 wyant [...] cpan.org - Correspondence added
Not a regression, but a bug in new functionality to look inside here documents. A correction has been uploaded as SVN commit 4058. The change to the policy in question is attached. Elliot -- I'm afraid this needs another release, since 1.114 only passed its self-test because the here document tests used one-line here documents.
Subject: rt67116.pat
Download rt67116.pat
application/octet-stream 987b

Message body not shown because it is not plain text.

  Thu Mar 31 11:31:53 2011 wyant [...] cpan.org - Status changed from 'open' to 'patched'
  Fri Apr 01 06:58:17 2011 EDAVIS [...] cpan.org - Correspondence added
Thanks for looking at this. The /()/ construct is just a minimal regexp used to reproduce the bug. I suppose it always matches, and sets $1 to the empty string.
  Fri Apr 01 06:58:17 2011 The RT System itself - Status changed from 'patched' to 'open'
  Wed Apr 20 13:31:02 2011 wyant [...] cpan.org - Status changed from 'open' to 'resolved'
  Wed Apr 20 13:31:02 2011 wyant [...] cpan.org - Fixed in 1.115 added