Bug #67094 for MARC-Record: Misleading error message from MARC::field new

Wed Mar 30 14:42:23 2011 chuck.schoppet [...] ars.usda.gov - Ticket created

Subject:

Misleading error message from MARC::field new

I tried to create a new 245 field with an empty subfield array and got a misleading message: Field 245 must have indicators (use ' ' for empty indicators) at C:\AGRICOLA\245_change_v2.pl line 144 Code: my @subfield_245 = []; my $new_field = MARC::Field->new( '245', '1', '0', @subfields_245 );

Mon May 30 20:31:15 2011 srdjan [...] catalyst.net.nz - Correspondence added

From:

srdjan [...] catalyst.net.nz

There's a bug in MARC::Field, lines 97-98. It reads: my $indicator = shift; scalar(@_) or croak("..."); Should be: my $indicator = shift or croak("...");

Mon May 30 20:31:16 2011 The RT System itself - Status changed from 'new' to 'open'

Mon May 30 20:35:28 2011 srdjan [...] catalyst.net.nz - Correspondence added

From:

srdjan [...] catalyst.net.nz

On Mon May 30 20:31:15 2011, srdjan@catalyst.net.nz wrote: Show quoted text

> There's a bug in MARC::Field, lines 97-98. It reads: > > my $indicator = shift; > scalar(@_) or croak("..."); > > Should be: > my $indicator = shift or croak("...");

Actually taking in account previous submission, it should be my $indicator = shift; defined( $indicator ) or croak("...");

Sat Feb 09 20:40:28 2013 GMCHARLT [...] cpan.org - Taken

Sat Feb 09 20:41:18 2013 GMCHARLT [...] cpan.org - Correspondence added

On Mon May 30 20:35:28 2011, srdjan@catalyst.net.nz wrote: Show quoted text

> Actually taking in account previous submission, it should be > > my $indicator = shift; > defined( $indicator ) or croak("...");

Thanks for the report. This is fixed in commit http://sourceforge.net/p/marcpm/code/ci/ab3329244b705b2356c76a45a5d1afd12df41991/, and I will upload a new release to CPAN shortly.

Sun Feb 10 23:28:33 2013 GMCHARLT [...] cpan.org - Correspondence added

Fixed in 2.0.4.

Sun Feb 10 23:28:34 2013 GMCHARLT [...] cpan.org - Status changed from 'open' to 'resolved'

Sun Feb 10 23:28:42 2013 GMCHARLT [...] cpan.org - Fixed in 2.0.4 added