Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the config-model CPAN distribution.

Report information
The Basics
Id: 67085
Status: resolved
Priority: 0/
Queue: config-model

People
Owner: DDUMONT [...] cpan.org
Requestors: roam [...] ringlet.net
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: (no value)
Fixed in: 1.236

Attachments


Subject: Accept the Package-Type binary control field
Hi, What do you think about the attached patch that will let Config-Model recognize the Package-Type: udeb and Package-Type: tdeb binary control fields found in some Debian packages? Thanks again for maintaining Config-Model! G'luck, Peter
Subject: 0001-Accept-the-Package-Type-binary-control-field.patch
From 865564d894322d0d2db281c8b830148256d62911 Mon Sep 17 00:00:00 2001 From: Peter Pentchev <roam@ringlet.net> Date: Wed, 30 Mar 2011 14:04:49 +0300 Subject: [PATCH] Accept the Package-Type binary control field. --- .../Model/models/Debian/Dpkg/Control/Binary.pl | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/lib/Config/Model/models/Debian/Dpkg/Control/Binary.pl b/lib/Config/Model/models/Debian/Dpkg/Control/Binary.pl index a382f16..638d40b 100644 --- a/lib/Config/Model/models/Debian/Dpkg/Control/Binary.pl +++ b/lib/Config/Model/models/Debian/Dpkg/Control/Binary.pl @@ -103,6 +103,14 @@ }, 'type' => 'list' }, + 'Package-Type', + { + 'value_type' => 'uniline', + 'summary' => 'The type of the package, if not a regular Debian one', + 'match' => '[tu]deb', + 'type' => 'leaf', + 'description' => 'If this field is present, the package is not a regular Debian package, but either a udeb generated for the Debian installer or a tdeb containing translated debconf strings.' + }, 'Synopsis', { 'value_type' => 'uniline', -- 1.7.4.1
On Wed Mar 30 13:09:06 2011, ROAM wrote: Show quoted text
> What do you think about the attached patch that will let Config-Model > recognize the Package-Type: udeb and Package-Type: tdeb binary control > fields found in some Debian packages?
Quite good ! It does the job. However using: value_type => 'enum', choice => [ 'tdeb', 'udeb' ] will yield more clear error messages in case of problems. Furthermore, using experience => 'advanced' would hide this parameter from the GUI for beginners. What do you think ? In any case, Package-Type will be part of next version. All the best
Subject: Re: [rt.cpan.org #67085] Accept the Package-Type binary control field
Date: Thu, 31 Mar 2011 15:49:12 +0300
To: Dominique Dumont via RT <bug-config-model [...] rt.cpan.org>
From: Peter Pentchev <roam [...] ringlet.net>
On Wed, Mar 30, 2011 at 02:19:10PM -0400, Dominique Dumont via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=67085 > > > On Wed Mar 30 13:09:06 2011, ROAM wrote:
> > What do you think about the attached patch that will let Config-Model > > recognize the Package-Type: udeb and Package-Type: tdeb binary control > > fields found in some Debian packages?
> > Quite good ! It does the job. > > However using: > > value_type => 'enum', > choice => [ 'tdeb', 'udeb' ] > > will yield more clear error messages in case of problems.
Right, I guess I'll really have to learn Config-Model's grammar at some point. Show quoted text
> Furthermore, using > > experience => 'advanced' > > would hide this parameter from the GUI for beginners.
Right... I guess I'll *really* have to learn Config-Model's grammar at some point! :) Show quoted text
> What do you think ? > > In any case, Package-Type will be part of next version.
Thanks for the quick reply and keep up the great work! G'luck, Peter -- Peter Pentchev roam@ringlet.net roam@FreeBSD.org peter@packetscale.com PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 Nostalgia ain't what it used to be.
Download signature.asc
application/pgp-signature 836b

Message body not shown because it is not plain text.

Hello I've applied your patch with the modifs I suggested. On Thu Mar 31 14:49:33 2011, ROAM wrote: Show quoted text
> Right... I guess I'll *really* have to learn Config-Model's grammar > at some point! :)
Learning Config-Model's should be easier with the GUI provided by config-model-edit (part of Config::Model::Itself). Config::Model::Manual::ModelCreationIntroduction doc is a good starting point to get an overview. All the best