Skip Menu |

This queue is for tickets about the signatures CPAN distribution.

Report information
The Basics
Id: 66997
Status: resolved
Priority: 0/
Queue: signatures

People
Owner: KAPPA [...] cpan.org
Requestors: KENTNL [...] cpan.org
SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.06
Fixed in: (no value)



Subject: Test failures since perl 5.13.7
See subject. An overview of test reports may be seen here: http://matrix.cpantesters.org/?dist=signatures&maxver= A sample fail report: http://www.cpantesters.org/cpan/report/e7d7d5be-561e-11e0-940f-c9eec7dfb23c Regards, Slaven
Subject: Re: [rt.cpan.org #66997] Test failures since perl 5.13.7
Date: Sun, 27 Mar 2011 17:58:02 +0100
To: bug-signatures [...] rt.cpan.org
From: Florian Ragwitz <rafl [...] debian.org>
"Slaven_Rezic via RT" <bug-signatures@rt.cpan.org> writes: Show quoted text
> Sun Mar 27 12:15:11 2011: Request 66997 was acted upon. > Transaction: Ticket created by SREZIC > Queue: signatures > Subject: Test failures since perl 5.13.7 > Broken in: 0.06 > Severity: (no value) > Owner: Nobody > Requestors: SREZIC@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=66997 > > > > See subject. An overview of test reports may be seen here: > http://matrix.cpantesters.org/?dist=signatures&maxver= > > A sample fail report: > http://www.cpantesters.org/cpan/report/e7d7d5be-561e-11e0-940f-c9eec7dfb23c
Same issue as with Devel::Declare. Once Devel::Declare is fixed, a fix for signatures could be extracted from there.
Download (untitled)
application/pgp-signature 197b

Message body not shown because it is not plain text.

Just bumping this bug for attention. Devel-Declare appears to work fine and dandy on 5.14.0 RC, so the solution might have been found =).
Subject: [rt.cpan.org #66997] Patch based on Devel::Declare
Date: Sun, 22 Apr 2012 18:40:01 +0100
To: bug-signatures [...] rt.cpan.org
From: Colin Watson <cjwatson [...] ubuntu.com>
Here's a patch against signatures-0.05 based loosely on what Devel::Declare is doing; it at least manages to pass tests with Perl 5.14.2. Does this look reasonably plausible? * Reallocate PL_linestr in a block hook to avoid reallocations; borrowed loosely from Devel::Declare. --- signatures-0.05.orig/signatures.xs +++ signatures-0.05/signatures.xs @@ -241,6 +241,16 @@ return ret; } +#if PERL_BCDVERSION >= 0x5013006 +STATIC void +block_start (pTHX_ int full) { + PERL_UNUSED_VAR (full); + + if (SvLEN (PL_linestr) < 16384) + lex_grow_linestr (16384); +} +#endif + STATIC OP * before_eval (pTHX_ OP *op, void *user_data) { dSP; @@ -293,12 +303,19 @@ char *f_class PREINIT: userdata_t *ud; +#if PERL_BCDVERSION >= 0x5013006 + static BHK bhk; +#endif INIT: Newx (ud, 1, userdata_t); ud->class = newSVsv (class); ud->f_class = f_class; CODE: ud->parser_id = hook_parser_setup (); +#if PERL_BCDVERSION >= 0x5013006 + BhkENTRY_set (&bhk, bhk_start, block_start); + Perl_blockhook_register (aTHX_ &bhk); +#endif ud->eval_hook = hook_op_check (OP_ENTEREVAL, handle_eval, ud); RETVAL = (UV)hook_op_check (OP_CONST, handle_proto, ud); OUTPUT: Thanks, -- Colin Watson [cjwatson@ubuntu.com]
Subject: Re: [rt.cpan.org #66997] Patch based on Devel::Declare
Date: Wed, 25 Apr 2012 13:05:02 +0200
To: bug-signatures [...] rt.cpan.org
From: Florian Ragwitz <rafl [...] debian.org>
"Colin Watson via RT" <bug-signatures@rt.cpan.org> writes: Show quoted text
> Queue: signatures > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=66997 > > > Here's a patch against signatures-0.05 based loosely on what > Devel::Declare is doing; it at least manages to pass tests with Perl > 5.14.2. Does this look reasonably plausible?
Very much so! Would you like to ship a trial release containing this change so we can see what the different smokers make of it?
Download (untitled)
application/pgp-signature 197b

Message body not shown because it is not plain text.

Срд Апр 25 07:05:23 2012, FLORA писал: Show quoted text
> "Colin Watson via RT" <bug-signatures@rt.cpan.org> writes: >
> > Queue: signatures > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=66997 > > > > > Here's a patch against signatures-0.05 based loosely on what > > Devel::Declare is doing; it at least manages to pass tests with Perl > > 5.14.2. Does this look reasonably plausible?
> > Very much so! > > Would you like to ship a trial release containing this change so we
can Show quoted text
> see what the different smokers make of it?
I have just done that instead of Colin (I just need signatures working by default on Ubuntu 12.04). Hope unofficial releases get the same amount of cpan testers love.
PASS reports are coming: http://www.cpantesters.org/distro/S/signatures.html#signatures-0.07 Looks like Windows compatibility is still broken but that will have to wait for an interested Windows developer.
Subject: Re: [rt.cpan.org #66997] Test failures since perl 5.13.7
Date: Sat, 02 Jun 2012 21:42:52 +0200
To: bug-signatures [...] rt.cpan.org
From: Florian Ragwitz <rafl [...] debian.org>
"Alex Kapranoff via RT" <bug-signatures@rt.cpan.org> writes: Show quoted text
Thanks very much. What's your CPAN id so I can grant you comaint for a stable release? Show quoted text
> Looks like Windows compatibility is still broken but that will have to > wait for an interested Windows developer.
Fair. I'm fine with Windows being broken as long as there's no new regressions being introduced.
Download (untitled)
application/pgp-signature 197b

Message body not shown because it is not plain text.

RT-Send-CC: rafl [...] debian.org
On Sun May 20 05:58:21 2012, KAPPA wrote: Show quoted text
> Looks like Windows compatibility is still broken but that will have to > wait for an interested Windows developer.
Problem is in B::Hooks::Parser. Reported in https://rt.cpan.org/Ticket/Display.html?id=77311 -- Alexandr Ciornii, http://chorny.net
On 2012-09-20 13:48:54, CHORNY wrote: Show quoted text
> On Sun May 20 05:58:21 2012, KAPPA wrote: >
> > Looks like Windows compatibility is still broken but that will have to > > wait for an interested Windows developer.
> > Problem is in B::Hooks::Parser. Reported in > https://rt.cpan.org/Ticket/Display.html?id=77311
B::Hooks::Parser 0.12 has been released.
RT-Send-CC: rafl [...] debian.org, cjwatson [...] ubuntu.com
Passing back to KAPPA - was anything else needed here?
Вск Май 12 02:08:40 2013, ETHER писал: Show quoted text
> Passing back to KAPPA - was anything else needed here?
Thanks! Let's just wait for positive Windows reports from cpantesters now.
This has been fixed, in the most recent releases of signatures and B-Hooks-Parser, for MSWin32 as well!