Skip Menu |

This queue is for tickets about the warnings-unused CPAN distribution.

Report information
The Basics
Id: 66929
Status: open
Priority: 0/
Queue: warnings-unused

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.04
Fixed in: (no value)



Subject: Tests fail with perl 5.13.1
It seems that "use warnings::unused" does not work anymore with perl 5.13.11: # Failed test 'use warnings::unused;' # at t/00_load.t line 4. # Tried to use 'warnings::unused'. # Error: Can't load '/var/tmp/CPAN-build/warnings-unused-0.04-Diu3lb/blib/arch/auto/warnings/unused/unused.so' for module warnings::unused: /var/tmp/CPAN-build/warnings-unused-0.04-Diu3lb/blib/arch/auto/warnings/unused/unused.so: Undefined symbol "Perl_refcounted_he_fetch" at /home/cpansand/var/ctps/2pre5140/install/perl-167630b6ab7e291cbd4f89943a3aec8d6a1ecbfc/lib/5.13.11/i386-freebsd/DynaLoader.pm line 190. # at (eval 4) line 2 # Compilation failed in require at (eval 4) line 2. # BEGIN failed--compilation aborted at (eval 4) line 2. # Testing warnings::unused 0.04 # Looks like you failed 1 test of 1. t/00_load.t ........ Regards, Slaven
From: raherh [...] gmail.com
On Sat Mar 26 06:51:44 2011, SREZIC wrote: Show quoted text
> It seems that "use warnings::unused" does not work anymore with perl > 5.13.11:
Unfortunately the same with perl 5.14.2. I hope the author will notice. Radek
Subject: Patch to fix Perl_refcounted_he_fetch()
From: perl [...] greerga.m-l.org
On Sat Mar 26 06:51:44 2011, SREZIC wrote: Show quoted text
> It seems that "use warnings::unused" does not work anymore with perl > 5.13.11:
Due to 20439bc77dfeec46d94a15cf108446039e26c995. -George
Subject: warnings-unused-0.04.patch
diff -upr warnings-unused-0.04/unused.xs warnings-unused-0.04x/unused.xs --- warnings-unused-0.04-stk/unused.xs 2009-02-28 04:33:08.000000000 -0500 +++ warnings-unused-0.04/unused.xs 2012-05-03 11:06:41.068158030 -0400 @@ -100,8 +100,8 @@ wl_scope_enabled(pTHX_ pMY_CXT){ #if PERL_BCDVERSION >= 0x5010000 if(PL_curcop->cop_hints_hash){ - SV* const sv = Perl_refcounted_he_fetch(aTHX_ - PL_curcop->cop_hints_hash, Nullsv, + SV* const sv = Perl_refcounted_he_fetch_pvn(aTHX_ + PL_curcop->cop_hints_hash, HINT_KEY, sizeof(HINT_KEY)-1, FALSE, 0); return sv && SvTRUE(sv); }
Thanks for the patch! Let's hope the author starts to support this module again, it'd be really nice to have it up and working again.