Skip Menu |

This queue is for tickets about the mod_perl CPAN distribution.

Report information
The Basics
Id: 66894
Status: resolved
Priority: 0/
Queue: mod_perl

People
Owner: Nobody in particular
Requestors: idl0r [...] qasl.de
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 2.0.5
Fixed in: (no value)



Subject: Apache::SizeLimit: Linux::Smaps detection broken
Hey guys, it looks like the Linux::Smaps detection should be improved to *not* die if /proc/self/smaps doesn't exist. It's quite easy by just moving the curly bracket. Please take a look at my patch where I it has been fixed already.
Subject: 0001-Fix-Linux-Smaps-detection-to-not-die-if-proc-self-sm.patch
From 6b1b60546ffca416a65d047a1c0d5d2b610b4dac Mon Sep 17 00:00:00 2001 From: Christian Ruppert <idl0r@gentoo.org> Date: Fri, 25 Mar 2011 17:42:54 +0100 Subject: [PATCH] Fix Linux::Smaps detection to *not* die if /proc/self/smaps doesn't exist --- lib/Apache/SizeLimit/Core.pm | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/Apache/SizeLimit/Core.pm b/lib/Apache/SizeLimit/Core.pm index 5942bc8..f2fbac4 100644 --- a/lib/Apache/SizeLimit/Core.pm +++ b/lib/Apache/SizeLimit/Core.pm @@ -143,7 +143,7 @@ BEGIN { *_platform_getppid = \&_linux_getppid; - if (eval { require Linux::Smaps } && Linux::Smaps->new($$)) { + if (eval { require Linux::Smaps && Linux::Smaps->new($$) }) { $USE_SMAPS = 1; *_platform_check_size = \&_linux_smaps_size_check; } -- 1.7.3.4
Resolved r1152635 Thanks for the patch, will go out with Apache::SizeLimit 0.96