Skip Menu |

This queue is for tickets about the MooseX-SlurpyConstructor CPAN distribution.

Report information
The Basics
Id: 66784
Status: resolved
Worked: 8 hours (480 min)
Priority: 0/
Queue: MooseX-SlurpyConstructor

People
Owner: ether [...] cpan.org
Requestors: ether [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.1
Fixed in: 1.2



Subject: Constructor is not inlined
The constructor in MX:SC is method-modified, and an inlined version is not produced for the meta->make_immutable call. This leads to warnings: Not inlining 'new' for MyApp::Foo since it has method modifiers which would be lost if it were inlined ..or having to change the make_immutable call to: __PACKAGE__->meta->make_immutable(inline_constructor => 0); Instead, we should produce an inlined version of the constructor, which will also make slurpy classes instantiate faster. I'm willing to do the work - I just don't know where your repository is. Please add this to META.yml or hit me up on irc #moose and we can discuss it. :) (PS. there are some coming changes with Moose 2.0 that will likely require changes, so these need to be discussed as well. Have you considered moving your repo to shadowcat next to Moose and many other MooseX modules so others can provide easy patches?)
Subject: Re: [rt.cpan.org #66784] Constructor is not inlined
Date: Wed, 23 Mar 2011 01:34:58 +0000
To: bug-MooseX-SlurpyConstructor [...] rt.cpan.org
From: Mark Morgan <makk384 [...] gmail.com>
Good day, Karen, Cheers for the notice on this, I don't use that module in my current role, so never realized it started throwing up errors. I'll have a look at resolving that over the weekend, hopefully it's just a matter of changing to wrap buildargs method, rather than new .. As to repo, I'll look to moving that one there, if it's become the standard for moose modules, I currently keep all my modules on github, to keep them central. I'll definitely drop into IRC, if I run into any issues in making the change. Cheers, Mark. On 22 Mar 2011 19:24, "Karen Etheridge via RT" < bug-MooseX-SlurpyConstructor@rt.cpan.org> wrote: Show quoted text
> Tue Mar 22 15:24:19 2011: Request 66784 was acted upon. > Transaction: Ticket created by ETHER > Queue: MooseX-SlurpyConstructor > Subject: Constructor is not inlined > Broken in: 1.1 > Severity: Important > Owner: Nobody > Requestors: ether@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=66784 > > > > The constructor in MX:SC is method-modified, and an inlined version is > not produced for the meta->make_immutable call. This leads to warnings: > > Not inlining 'new' for MyApp::Foo since it has method modifiers which > would be lost if it were inlined > > ..or having to change the make_immutable call to: > __PACKAGE__->meta->make_immutable(inline_constructor => 0); > > Instead, we should produce an inlined version of the constructor, which > will also make slurpy classes instantiate faster. > > I'm willing to do the work - I just don't know where your repository is. > Please add this to META.yml or hit me up on irc #moose and we can > discuss it. :) > > (PS. there are some coming changes with Moose 2.0 that will likely > require changes, so these need to be discussed as well. Have you > considered moving your repo to shadowcat next to Moose and many other > MooseX modules so others can provide easy patches?)
If you're not using this module anymore, I'd be happy to take over maint on it and fix the outstanding issues (there is this ticket, RT#66785, and also a mysterious double-free of a SV when used with MooseX::Role::Parameterized) -- given the upcoming Moose 2.0 changes, a nearly full-rewrite is merited at this point anyway. Let me know, or come find me on #moose - I'm around most of the day (west coast North America time).
Subject: Re: [rt.cpan.org #66784] Constructor is not inlined
Date: Sat, 26 Mar 2011 22:28:57 +0000
To: bug-MooseX-SlurpyConstructor [...] rt.cpan.org
From: Mark Morgan <makk384 [...] gmail.com>
Heya Karen, If you're willing to take it over, you're welcome to do so if still interested. I only started maintaining it on github with the current version, though previous is still up on CPAN. I'll have no problem taking it back, if you decide it the future that you don't have time for it... Take care, Mark. On 23 March 2011 18:19, Karen Etheridge via RT < bug-MooseX-SlurpyConstructor@rt.cpan.org> wrote: Show quoted text
> Queue: MooseX-SlurpyConstructor > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=66784 > > > If you're not using this module anymore, I'd be happy to take over maint > on it and fix the outstanding issues (there is this ticket, RT#66785, > and also a mysterious double-free of a SV when used with > MooseX::Role::Parameterized) -- given the upcoming Moose 2.0 changes, a > nearly full-rewrite is merited at this point anyway. > > Let me know, or come find me on #moose - I'm around most of the day > (west coast North America time). >
Subject: Re: [rt.cpan.org #66784] Constructor is not inlined
Date: Mon, 28 Mar 2011 11:53:17 -0700
To: Mark Morgan via RT <bug-MooseX-SlurpyConstructor [...] rt.cpan.org>
From: Karen Etheridge <karen [...] etheridge.ca>
I'm definitely interested -- as I have an upcoming project which will make use of this extension, I'm willing to put in some time to getting things set up/working/etc. Comaint is fine with me (I certainly don't want you to have to give up any control over the module) -- if you like I can also get one of the shadowcat admins to create a spot for the repository under http://git.shadowcat.co.uk/gitweb/gitweb.cgi. On Sat, Mar 26, 2011 at 06:29:06PM -0400, Mark Morgan via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=66784 > > > Heya Karen, > > If you're willing to take it over, you're welcome to do so if still > interested. I only started maintaining it on github with the current > version, though previous is still up on CPAN. I'll have no problem taking > it back, if you decide it the future that you don't have time for it... > > Take care, > Mark. > > On 23 March 2011 18:19, Karen Etheridge via RT < > bug-MooseX-SlurpyConstructor@rt.cpan.org> wrote: >
> > Queue: MooseX-SlurpyConstructor > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=66784 > > > > > If you're not using this module anymore, I'd be happy to take over maint > > on it and fix the outstanding issues (there is this ticket, RT#66785, > > and also a mysterious double-free of a SV when used with > > MooseX::Role::Parameterized) -- given the upcoming Moose 2.0 changes, a > > nearly full-rewrite is merited at this point anyway. > > > > Let me know, or come find me on #moose - I'm around most of the day > > (west coast North America time). > >
-- "I felt a kind of forlorn sense of being lost in a world of incredibly stupid and malicious dwarfs." - Aleister Crowley . . . . . Karen Etheridge, karen@etheridge.ca GCS C+++$ USL+++$ P+++$ w--- M++
RT-Send-CC: karen [...] etheridge.ca, makk384 [...] gmail.com
Fixed in 1.2.