Good day, Karen,
Cheers for the notice on this, I don't use that module in my current role,
so never realized it started throwing up errors. I'll have a look at
resolving that over the weekend, hopefully it's just a matter of changing to
wrap buildargs method, rather than new ..
As to repo, I'll look to moving that one there, if it's become the standard
for moose modules, I currently keep all my modules on github, to keep them
central.
I'll definitely drop into IRC, if I run into any issues in making the
change.
Cheers,
Mark.
On 22 Mar 2011 19:24, "Karen Etheridge via RT" <
bug-MooseX-SlurpyConstructor@rt.cpan.org> wrote:
Show quoted text> Tue Mar 22 15:24:19 2011: Request 66784 was acted upon.
> Transaction: Ticket created by ETHER
> Queue: MooseX-SlurpyConstructor
> Subject: Constructor is not inlined
> Broken in: 1.1
> Severity: Important
> Owner: Nobody
> Requestors: ether@cpan.org
> Status: new
> Ticket <URL:
https://rt.cpan.org/Ticket/Display.html?id=66784 >
>
>
> The constructor in MX:SC is method-modified, and an inlined version is
> not produced for the meta->make_immutable call. This leads to warnings:
>
> Not inlining 'new' for MyApp::Foo since it has method modifiers which
> would be lost if it were inlined
>
> ..or having to change the make_immutable call to:
> __PACKAGE__->meta->make_immutable(inline_constructor => 0);
>
> Instead, we should produce an inlined version of the constructor, which
> will also make slurpy classes instantiate faster.
>
> I'm willing to do the work - I just don't know where your repository is.
> Please add this to META.yml or hit me up on irc #moose and we can
> discuss it. :)
>
> (PS. there are some coming changes with Moose 2.0 that will likely
> require changes, so these need to be discussed as well. Have you
> considered moving your repo to shadowcat next to Moose and many other
> MooseX modules so others can provide easy patches?)