Bug #66681 for LWP-MediaTypes: Missing requires in META.yml

Thu Mar 17 04:57:17 2011 ppisar [...] redhat.com - Ticket created

Subject:

Missing requires in META.yml

I think Data::Dumper and File::Basename are missing in META.yml requires section. The File::Basename is required in file_exts() that is called from public guess_media_type(). The Data::Dumper is required in a function that is never called (except a comment in a tests), but it would be good to remove the dead code or put it to META.yml.

Sat Jan 21 07:17:30 2012 ribasushi [...] leporine.io - Correspondence added

On Thu Mar 17 04:57:17 2011, ppisar wrote: Show quoted text

> I think Data::Dumper and File::Basename are missing in META.yml requires > section. > > The File::Basename is required in file_exts() that is called from public > guess_media_type(). > > The Data::Dumper is required in a function that is never called (except > a comment in a tests), but it would be good to remove the dead code or > put it to META.yml.

Both of these modules have been shipped as part of perl itself since perl 5.0. As such there is no requirement of having them part of the dependency declarations.

Sat Jan 21 07:17:32 2012 The RT System itself - Status changed from 'new' to 'open'

Thu Feb 16 16:17:54 2012 GAAS [...] cpan.org - Correspondence added

I removed the _dump() function and thus the Data::Dumper reference. I agree that there should ok to assume File::Basename is available as a core perl module.

Thu Feb 16 16:17:55 2012 GAAS [...] cpan.org - Status changed from 'open' to 'resolved'