Bug #66610 for Sys-Filesystem: [Patch] Handle mount points containing whitespace.

Mon Mar 14 19:41:51 2011 perl [...] galumph.com - Ticket created

Subject:	[Patch] Handle mount points containing whitespace.
Date:	Mon, 14 Mar 2011 18:41:34 -0500
To:	bug-Sys-Filesystem [...] rt.cpan.org
From:	Elliot Shank <perl [...] galumph.com>

I've got mount points containing whitespace. On Linux, this means that /proc/self/mounts ends up containing things like "/foo/bar\040baz". Attached is a patch that deals with C-style escapes in mount points. It uses a string-eval to deal with this; not the nicest thing in the world, but there doesn't seem to be any module that does it and Perl::Critic gets away with it. :] The patch is in two forms: one complete one that does everything or three that do the change piecewise. Partial patch 1 changes Sys::Filesystem::Unix to use a $mount_point variable everywhere instead of "$vals[ $pridx->[1] ]". Partial patch 2 adds a cleanUpMountPoint() method to Sys::Filesystem::Unix and uses that to deal with the C-style escapes. Partial patch 3 changes Sys::Filesystem::Linux to use cleanUpMountPoint().

Message body is not shown because sender requested not to inline it.

Tue Mar 15 02:24:40 2011 REHSACK [...] cpan.org - Correspondence added

I accept the issue - even when I do not rate it higher than wish list. Someone creating mount points containing white spaces is asking for trouble. I reject your patches - did you run tests with them o.O Some rules if you plan to rework them: 1) do not break other OS by fixing one 2) do not introduce global variables unless necessary 3) run "build test" before submitting them Best regards, Jens

Tue Mar 15 02:24:41 2011 The RT System itself - Status changed from 'new' to 'open'

Tue Mar 15 07:38:13 2011 perl [...] galumph.com - Correspondence added

Subject:	Re: [rt.cpan.org #66610] [Patch] Handle mount points containing whitespace.
Date:	Tue, 15 Mar 2011 06:38:02 -0500
To:	bug-Sys-Filesystem [...] rt.cpan.org
From:	Elliot Shank <perl [...] galumph.com>

On 3/15/11 1:24 AM, Jens Rehsack via RT wrote: Show quoted text

> I reject your patches - did you run tests with them o.O

Yes, I did. What failed for you? Show quoted text

> Someone creating mount points containing white spaces is asking for trouble.

In the example in the POD, that's the path that Ubuntu creates when you hook up an iPod. At work, I've got to deal with Samba mounts of shares containing whitespace. Show quoted text

> Some rules if you plan to rework them: > 1) do not break other OS by fixing one

If I did, I did not intend to. Show quoted text

> 2) do not introduce global variables unless necessary

What global variable? Show quoted text

> 3) run "build test" before submitting them

The plain v1.30 tests fail for me and pass with my changes. Thank you for considering this.

Tue Sep 03 08:15:26 2013 REHSACK [...] cpan.org - Correspondence added

Please redo the patches - including tests and do a pull-request. Please do the fixes in the manner I asked you (I hope kindly enough ^^).

Tue Sep 03 08:15:26 2013 REHSACK [...] cpan.org - Status changed from 'open' to 'stalled'

Tue May 13 09:20:54 2014 REHSACK [...] cpan.org - Status changed from 'stalled' to 'open'

Tue May 13 09:22:17 2014 REHSACK [...] cpan.org - Correspondence added

No feedback since 3 years and suspicious patches which causes other systems to fail.

Tue May 13 09:22:18 2014 REHSACK [...] cpan.org - Status changed from 'open' to 'rejected'

Fri May 16 00:03:47 2014 perl [...] galumph.com - Correspondence added

Subject:	Re: [rt.cpan.org #66610] [Patch] Handle mount points containing whitespace.
Date:	Thu, 15 May 2014 23:03:33 -0500
To:	bug-Sys-Filesystem [...] rt.cpan.org
From:	Elliot Shank <perl [...] galumph.com>

On 5/13/14, 8:22 AM, Jens Rehsack via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=66610 > > > No feedback since 3 years and suspicious patches which causes other systems to fail.

Did you ever answer any of my questions? No. Did you ever specify "other systems"? No. Did you ever specify any failures? No. I don't know how you expect issues to be addressed when you don't give any details.