Bug #66575 for Image-PNG-Rewriter: Fails if GD is not available

Sat Mar 12 11:30:24 2011 ANDK [...] cpan.org - Ticket created

Subject:

Fails if GD is not available

The test t/02gd.t has the best intention to skip all tests when GD is not available. But then it has a use GD 'GD_CMP_IMAGE'; on line 35 which causes the test to fail at compile time, i.e. before the eval "use GD" is executed. This would work (tested): 35 GD->import('GD_CMP_IMAGE'); 36 my $gd2 = GD::Image->newFromPngData($re_png, 1); 37 ok(!($gd->compare($gd2) & GD::GD_CMP_IMAGE())); HTH,

Sat Mar 12 15:04:23 2011 derhoermi [...] gmx.net - Correspondence added

Subject:	Re: [rt.cpan.org #66575] Fails if GD is not available
Date:	Sat, 12 Mar 2011 21:04:06 +0100
To:	bug-Image-PNG-Rewriter [...] rt.cpan.org
From:	Bjoern Hoehrmann <derhoermi [...] gmx.net>

* Andreas Koenig via RT wrote: Show quoted text

>The test t/02gd.t has the best intention to skip all tests when GD is >not available. But then it has a > > use GD 'GD_CMP_IMAGE'; > >on line 35 which causes the test to fail at compile time, i.e. before >the eval "use GD" is executed. > >This would work (tested): > > 35 GD->import('GD_CMP_IMAGE'); > 36 my $gd2 = GD::Image->newFromPngData($re_png, 1); > 37 ok(!($gd->compare($gd2) & GD::GD_CMP_IMAGE()));

Yeah, I thought `GD::GD_CMP_IMAGE` would work after the initial `use` but it did not so I put in the other use, thought I tested this works, but apparently I failed. I've uploaded a new version with your fix. Thank you, -- Björn Höhrmann · mailto:bjoern@hoehrmann.de · http://bjoern.hoehrmann.de Am Badedeich 7 · Telefon: +49(0)160/4415681 · http://www.bjoernsworld.de 25899 Dagebüll · PGP Pub. KeyID: 0xA4357E78 · http://www.websitedev.de/

Sat Mar 12 15:04:24 2011 The RT System itself - Status changed from 'new' to 'open'

Sat Mar 12 15:10:26 2011 BJOERN [...] cpan.org - Status changed from 'open' to 'resolved'