Skip Menu |

This queue is for tickets about the Algorithm-LBFGS CPAN distribution.

Report information
The Basics
Id: 66541
Status: open
Priority: 0/
Queue: Algorithm-LBFGS
People
Owner: Nobody in particular
Requestors: DKOGAN [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 0.16
Fixed in: (no value)

History Show all quoted text
  Fri Mar 11 03:14:00 2011 DKOGAN [...] cpan.org - Ticket created
status_ok() currently checks for status == 0, instead it should check for status eq 'LBFGS_OK'
  Sat Nov 17 15:57:10 2012 DKOGAN [...] cpan.org - Correspondence added
Subject: PATCH: more correctly check the status
On Fri Mar 11 03:14:00 2011, DKOGAN wrote: Show quoted text
> status_ok() currently checks for status == 0, instead it should check
for Show quoted text
> status eq 'LBFGS_OK'
Subject: 0001-status_ok-now-checks-the-error-code-correctly.patch
From: Dima Kogan <dima@secretsauce.net> Date: Sat, 17 Nov 2012 12:18:24 -0800 Subject: status_ok() now checks the error code correctly Forwarded: yes --- lib/Algorithm/LBFGS.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Algorithm/LBFGS.pm b/lib/Algorithm/LBFGS.pm index ec29482..2cb7c68 100644 --- a/lib/Algorithm/LBFGS.pm +++ b/lib/Algorithm/LBFGS.pm @@ -88,7 +88,7 @@ sub get_status { return $self->{status}; } -sub status_ok { return get_status(@_) == 0; } +sub status_ok { return get_status(@_) eq 'LBFGS_OK'; } 1;
  Sat Nov 17 15:57:11 2012 DKOGAN [...] cpan.org - Status changed from 'new' to 'open'