| Subject: | upload() should close un-used $tmp_fh |
Based on my experience working with a private fork of this project, I
think the upload() method should call close() on the $tmp_fh.
I found that when our fork was used in a long running process, the max
limit of open files was eventually reached. This may not come up in the
average use of web development, but appears to have an easy fix with no
downsides.
A test script could be devised which calls uploads multiple times, while
a second terminal is used to call "lsof" or "fstat" to see if the open
file count is increasing or constant.