Bug #66207 for Test: t/todo.t not safe on case-insensitive filesystems

Sat Feb 26 15:01:35 2011 dmacks [...] netspace.org - Ticket created

Subject:	t/todo.t not safe on case-insensitive filesystems
Date:	Sat, 26 Feb 2011 15:01:27 -0500
To:	bug-Test [...] rt.cpan.org
From:	"Daniel Macks" <dmacks [...] netspace.org>

Unpacking Test-1.25, I see there is a TODO file. After the usual perl Makefile.PL make make test that file is gone. I am on OS X, where the default filesystem is case-insensitive. The bug is in t/todo.t, where "todo" is used as a temporary file and then unlinked when no longer needed. On my FS, "todo" and "TODO" are the same file, so the distribution file gets clobbered. I don't understand the Test::Harness issue being described in todo.t, for which the use of the todo file is an apparent work-around. But could it simply use a different filename? Or more portably, could it use a File::Temp tempfile? dan -- Daniel Macks dmacks@netspace.org

Sat Feb 26 20:30:16 2011 mschwern [...] cpan.org - Correspondence added

Yes, it should use a different filename or File::Temp. File::Temp wasn't shipped with the core when that test was written. If Test.pm wants to drop 5.5.x support, it could just use scalar reference filehandles. Furthermore, it's testing an outmoded style of todo tests. As a side note, if you're actively using Test.pm you should transition away from it to something Test::Builder based. This lets you use other Test:: modules on CPAN together in your tests. Test::Legacy provides the same interface as Test.pm and allows you to use Test::More and others together in the same script.

Sat Feb 26 20:30:16 2011 The RT System itself - Status changed from 'new' to 'open'

Sat Feb 26 23:02:01 2011 jesse [...] fsck.com - Correspondence added

Subject:	Re: [rt.cpan.org #66207] t/todo.t not safe on case-insensitive filesystems
Date:	Sat, 26 Feb 2011 20:01:46 -0800
To:	bug-Test [...] rt.cpan.org
From:	Jesse Vincent <jesse [...] fsck.com>

Michael G Schwern via RT <bug-Test@rt.cpan.org> wrote: Queue: Test Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=66207 > Yes, it should use a different filename or File::Temp. File::Temp wasn't shipped with the core when that test was written. If Test.pm wants to drop 5.5.x support, it could just use scalar reference filehandles. Furthermore, it's testing an outmoded style of todo tests. As a side note, if you're actively using Test.pm you should transition away from it to something Test::Builder based. This lets you use other Test:: modules on CPAN together in your tests. Test::Legacy provides the same interface as Test.pm and allows you to use Test::More and others together in the same script. Test.pm is stable in the biological sense. It's unlikely to drop 5.5 support. -- Sent from my Android phone with K-9 Mail. Please excuse my brevity.

Sun Feb 27 05:44:34 2011 dmacks [...] netspace.org - Correspondence added

Subject:	Re: [rt.cpan.org #66207] t/todo.t not safe on case-insensitive filesystems
Date:	Sun, 27 Feb 2011 05:44:21 -0500
To:	bug-Test [...] rt.cpan.org
From:	"Daniel Macks" <dmacks [...] netspace.org>

On Sat, 26 Feb 2011 20:30:16 -0500, Michael G Schwern via RT wrote: Show quoted text

> > As a side note, if you're actively using Test.pm you should transition > away from it to something Test::Builder based.

My only "active" use of Test.pm is that it's a dependency of Pod::Simple. Is there a CPAN-data reverse-dependency scanner that can find all such modules that are still actively using this one? dan

Sun Feb 27 07:09:08 2011 schwern [...] pobox.com - Correspondence added

Subject:	Re: [rt.cpan.org #66207] t/todo.t not safe on case-insensitive filesystems
Date:	Sun, 27 Feb 2011 23:08:51 +1100
To:	bug-Test [...] rt.cpan.org
From:	Michael G Schwern <schwern [...] pobox.com>

On 2011.2.27 9:44 PM, dmacks@netspace.org via RT wrote: Show quoted text

> My only "active" use of Test.pm is that it's a dependency of > Pod::Simple.

That can probably be fixed now that David Wheeler is maintaining it. Either convert the tests to Test::More, which is just a bunch of rote work, or s/use Test;/use Test::Legacy;/ Show quoted text

> Is there a CPAN-data reverse-dependency scanner that can > find all such modules that are still actively using this one?

CPANTS could do that, but it's been down for a while. -- I am somewhat preoccupied telling the laws of physics to shut up and sit down. -- Vaarsuvius, "Order of the Stick" http://www.giantitp.com/comics/oots0107.html