Skip Menu |

This queue is for tickets about the Test-EOL CPAN distribution.

Report information
The Basics
Id: 66177
Status: resolved
Priority: 0/
Queue: Test-EOL

People
Owner: Nobody in particular
Requestors: b2gills [...] gmail.com
ether [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: 1.5



Subject: Don't use FindBin
Currently Test::EOL checks for files one directory up from the file that runs it. Which is fine if it exists in t/ or xt/. It is not fine when it is in the file xt/release/eol.t which happens if you use the Dist::Zilla plugin EOLTests without using the plugin ExtraTests. The easiest way to fix this is to just use the current working directory. Generally when you run test files, you do so from the base directory. At most I would check to see if the CWD is the same as $FindBin::Bin, and in that case go up one directory. --- I was going to have a Git pre-commit hook that ran dzil xtests, which requires not using the plugin ExtraTests.
Le 2011-02-25 20:08:28, BGILLS a écrit : Show quoted text
> The easiest way to fix this is to just use the current working > directory.
I agree. Show quoted text
> I was going to have a Git pre-commit hook that ran dzil xtests, which > requires not using the plugin ExtraTests.
Yes, ExtraTests is evil. -- Olivier Mengué - http://perlresume.org/DOLMEN
I've fixed this in the latest release. Thanks for the feedback!
Subject: looking for files in the wrong dir(s)
This module assumes that it is running out of something like t/no-tabs.t. When it is instead run out of xt/release/no-tabs.t, it fails to find any .pm files, because it only looks one directory up. It should actually be looking relative to the CWD, not where the test is located. I can fix this in Dist::Zilla::Plugin::EOLTests (by doing a file-find there and passing the files one at a time to eol_unix_ok(), but it would be better to fix it here, once and for all. (note this is the identical problem as in Test::NoTabs, and I plan to fix both simultaneously.)