Skip Menu |

This queue is for tickets about the Text-Markdown-Discount CPAN distribution.

Report information
The Basics
Id: 66012
Status: resolved
Priority: 0/
Queue: Text-Markdown-Discount

People
Owner: Nobody in particular
Requestors: dwheeler [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: New Version?
Date: Mon, 21 Feb 2011 15:24:08 -0800
To: bug-text-markdown-discount [...] rt.cpan.org
From: "David E. Wheeler" <dwheeler [...] cpan.org>
Howdy, Looks like Text::Markdown::Discount hasn't been updated since October 2009. It embeds Discount 1.3.4. The latest, though, is 2.0.7. Any chance of an upgrade? Thanks, David
On Mon Feb 21 18:24:17 2011, DWHEELER wrote: Show quoted text
> Howdy, > > Looks like Text::Markdown::Discount hasn't been updated since October > 2009. It embeds Discount 1.3.4. The latest, though, is 2.0.7. Any > chance of an upgrade? > > Thanks, > > David
The attached patch will make the perl module build against the system's installed libmarkdown2 library, rather than the embedded copy of discount. Seems to work ok with 2.1.2.
Subject: discount.patch
diff -ur 2/Text-Markdown-Discount-0.01/Makefile.PL Text-Markdown-Discount-0.01/Makefile.PL --- 2/Text-Markdown-Discount-0.01/Makefile.PL 2009-10-19 18:38:26.000000000 -0400 +++ Text-Markdown-Discount-0.01/Makefile.PL 2012-01-01 17:50:45.049822343 -0400 @@ -4,10 +4,7 @@ use ExtUtils::MakeMaker; use File::Spec; -my $extdir = 'discount-1.3.4'; -my $myextlib = File::Spec->catfile($extdir, 'libmarkdown.a'); my $clean_files = join (" ", - map{ File::Spec->catfile($extdir, $_) } qw ( markdwon mkd2html makepage theme libmarkdown.a Csio.o @@ -36,12 +33,6 @@ -sub MY::postamble { - return sprintf(' -$(MYEXTLIB): - %s -', qq{( cd $extdir; sh configure.sh; make )\n}); -} WriteMakefile( NAME => 'Text::Markdown::Discount', @@ -50,8 +41,6 @@ ($] >= 5.005 ? (ABSTRACT_FROM => 'lib/Text/Markdown/Discount.pm', AUTHOR => 'Masayoshi Sekimura <sekimura@cpan.org>') : ()), - LIBS => '-L' . $extdir, - INC => '-I. -I' . $extdir, - MYEXTLIB => $myextlib, + MYEXTLIB => "/usr/lib/libmarkdown.so", clean => { FILES => $clean_files }, );
Hi David, Hooray, I've just uploaded v0.02 with Discount 2.1.2 and it will be indexed "shortly". Let me know if you have any problem with the new one. Thank you, --Masa On Mon Feb 21 18:24:17 2011, DWHEELER wrote: Show quoted text
> Howdy, > > Looks like Text::Markdown::Discount hasn't been updated since October > 2009. It embeds Discount 1.3.4. The latest, though, is 2.0.7. Any > chance of an upgrade? > > Thanks, > > David