Skip Menu |

This queue is for tickets about the Net-Stomp CPAN distribution.

Report information
The Basics
Id: 65979
Status: resolved
Priority: 0/
Queue: Net-Stomp

People
Owner: Nobody in particular
Requestors: vigith [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Bugs in Net-Stomp-0.40
Date: Mon, 21 Feb 2011 11:26:36 +0530
To: bug-Net-Stomp [...] rt.cpan.org
From: vigith maurice <vigith [...] gmail.com>
**There are few bugs in Net-Stomp perl client ( http://cpansearch.perl.org/src/ASH/Net-Stomp-0.40/lib/Net/Stomp.pm). For Eg, 1. foreach my $host (split(/,/,$uris)) { my ($hostname, $port) = ($host =~ m{^\w+://([a-zA-Z0-9\-./]+):([0-9]+)$}) || confess "Unable to parse failover component: '$host'"; push(@hosts, {hostname => $hostname, port => $port}); } $hostname will be set to 1 and $port to undef so failover never works. 2. # Or in a more natural perl way $stomp = Net::Stomp->new({ hosts => [ { hostname => 'primary', port => 61616 }, { hostname => 'secondary', port => 61616 }, ] }); this never works if the first host fails to respond. can you please point to any code repository where i can submit the patch. Please correct me if i am wrong. -- regards, vigith maurice
Entierly possible that this doesn't work well/at all as it was a third party patch that I picked up when I started maintaining this module. The source code lives in https://github.com/ashb/net-stomp/
From: vigith [...] gmail.com
On Mon Feb 21 03:59:27 2011, ASH wrote: Show quoted text
> The source code lives in https://github.com/ashb/net-stomp/
I have made a Pull Request for the patch i have written. Please review and merge. Incase of any bugs please let me know. -vm
From: vigith [...] gmail.com
Hi Ash Berlin, Can you please merge this pull request https://github.com/ashb/net-stomp/pulls. It will be really great if you can release the new package as i am currently blocked due to this. Thanks, -vm
Fixed in v0.41 that just got released to CPAN