Skip Menu |

This queue is for tickets about the IO-Async-Loop-POE CPAN distribution.

Report information
The Basics
Id: 65706
Status: resolved
Priority: 0/
Queue: IO-Async-Loop-POE

People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.03
Fixed in: 0.04



Subject: Fails since POE 1.299 is out
Example fail report http://www.cpantesters.org/cpan/report/27e8355a-3300-11e0-a88e-ba1025f9cbe5 I have downgraded one of my smokers to POE 1.294 and then the tests in IO::Async::Loop::POE passed again. HTH, Regards,
On Mon Feb 14 02:20:39 2011, ANDK wrote: Show quoted text
> Example fail report > >
http://www.cpantesters.org/cpan/report/27e8355a-3300-11e0-a88e-ba1025f9cbe5 Show quoted text
> > I have downgraded one of my smokers to POE 1.294 and then the tests in > IO::Async::Loop::POE passed again. > > HTH, Regards,
Ah yes; code change in POE 1.299. Now fixed, see attached patch. Fixed in 0.04, uploaded to CPAN about 5 minutes ago. -- Paul Evans
Subject: rt65706.patch
=== modified file 'lib/IO/Async/Loop/POE.pm' --- lib/IO/Async/Loop/POE.pm 2011-02-21 19:33:45 +0000 +++ lib/IO/Async/Loop/POE.pm 2011-02-21 21:35:12 +0000 @@ -104,10 +104,11 @@ $_[KERNEL]->alarm_set( invoke => $_[ARG0], $_[ARG1] ); }, alarm_reset => sub { - # TODO: POE docs claim we get an ARRAY ref back here, but testing - # suggests it's just a list + # POE docs claim we get an ARRAY ref back here, but up until 1.299 + # it returned a plain list. my ( undef, undef, $data ) = $_[KERNEL]->alarm_remove( $_[ARG0] ); - $_[KERNEL]->alarm_set( invoke => $_[ARG1], $data ); + my $code = ( ref $data eq "ARRAY" ) ? $data->[0] : $data; + $_[KERNEL]->alarm_set( invoke => $_[ARG1], $code ); }, delay_set => sub { $_[KERNEL]->delay_set( invoke => $_[ARG0], $_[ARG1] );
Should now be fixed. -- Paul Evans