Skip Menu |

This queue is for tickets about the Devel-Callsite CPAN distribution.

Report information
The Basics
Id: 65625
Status: resolved
Priority: 0/
Queue: Devel-Callsite

People
Owner: Rocky Bernstein (no email address)
Requestors: MATTP [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.04
Fixed in: (no value)



Subject: Tests failing on Perl 5.12.3
Hi Teodor, I'm seeing a test failure on the latest perl (Seen on Ubuntu 10.10 : # Failed test 'Valid context call' # at t/basic.t line 13. # Looks like you failed 1 test of 6. t/basic.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/6 subtests I've attached the full build.log. I've fixed the failures with the following change : [~/.cpanm/work/1297357959.29178/Devel-Callsite-0.04] $ diff Callsite.xs.old Callsite.xs 29c29 < RETVAL = PTR2UV(Perl_get_context()); --- Show quoted text
> RETVAL = PTR2UV(PERL_GET_CONTEXT);
(patch attached) This fixes the test failure, though I am not familiar enough with perl internals to know if this is a valid fix. Thanks diagnostic info: This is perl 5, version 12, subversion 3 (v5.12.3) built for x86_64-linux Linux name 2.6.35.4-rscloud #8 SMP Mon Sep 20 15:54:33 UTC 2010 x86_64 GNU/Linux Devel-Callsite-0.04
Subject: Callsite.xs.patch
*** Callsite.xs.old Thu Feb 10 17:23:42 2011 --- Callsite.xs Thu Feb 10 17:23:53 2011 *************** callsite() *** 26,31 **** IV context() CODE: ! RETVAL = PTR2UV(Perl_get_context()); OUTPUT: RETVAL --- 26,31 ---- IV context() CODE: ! RETVAL = PTR2UV(PERL_GET_CONTEXT); OUTPUT: RETVAL
Subject: build.log
Download build.log
application/octet-stream 2.6k

Message body not shown because it is not plain text.

Commit 851eca63d3 of https://github.com/rocky/Perl-Devel-Callsite now has your patch. Thanks! Please double check though since I make mistakes. Thanks again for the patch. On Thu Feb 10 12:26:58 2011, MATTP wrote: Show quoted text
> Hi Teodor, > I'm seeing a test failure on the latest perl (Seen on Ubuntu 10.10 : > > # Failed test 'Valid context call' > # at t/basic.t line 13. > # Looks like you failed 1 test of 6. > t/basic.t .. > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/6 subtests > > I've attached the full build.log. > > I've fixed the failures with the following change : > [~/.cpanm/work/1297357959.29178/Devel-Callsite-0.04] $ diff > Callsite.xs.old Callsite.xs > 29c29 > < RETVAL = PTR2UV(Perl_get_context()); > ---
> > RETVAL = PTR2UV(PERL_GET_CONTEXT);
> > (patch attached) > This fixes the test failure, though I am not familiar enough with perl > internals to know if this is a valid fix. > > Thanks > > diagnostic info: > This is perl 5, version 12, subversion 3 (v5.12.3) built for x86_64-linux > Linux name 2.6.35.4-rscloud #8 SMP Mon Sep 20 15:54:33 UTC 2010 x86_64 > GNU/Linux > Devel-Callsite-0.04
I've just released version 0.05 which has your patch. Thanks again.