Skip Menu |

This queue is for tickets about the Test-MTA-Exim4 CPAN distribution.

Report information
The Basics
Id: 65602
Status: resolved
Priority: 0/
Queue: Test-MTA-Exim4

People
Owner: Nobody in particular
Requestors: tlyons [...] ivenue.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.03
Fixed in: 0.04



Subject: exim -bV output has changed slightly
The output of exim -bV has changed slightly WRT to lookups. Instead of Lookups: blah1 blah2 it now does: Lookups (built-in): lsearch wildlsearch nwildlsearch iplsearch cdb dbm dbmnz dnsdb dsearch ldap ldapdn ldapm nis nis0 nisplus passwd sqlite and if the patches in bug #139 ever get accepted, there will be another line of output that may look something like this: Lookups (as-module): mysql spf The quick hacky way that I implemented it was: # check that binary has various lookups foreach (qw[lsearch wildlsearch nwildlsearch dnsdb]) { $exim->has_capability( 'lookups_built_in', $_ ); } foreach (qw[mysql spf]) { $exim->has_capability( 'lookups_as_module', $_ ); } But there are inconsistencies with the above usage: 1. "lookup", singular, was the original, and I think it should stay that way for consistency. 2. The test code really shouldn't care whether it is built in or is a module, only that it is present. This requires some extra parsing logic in _run_exim_bv() specific to the potential different lookup types it will report. 3. I think it should also track the different class (built-in or as-module) of $type "lookup", but I can't think of a reason yet why that would be important. Attached a patch which should strip values in parenthesis (but after the transformation to underscores). It does not store the class of the lookup (built-in or as-module). I feel it needs work and can possibly be altered to just strip everything after ^lookup, for simplicity sake.
Subject: test-mta-exim4.patch
From: tlyons [...] ivenue.com
On Wed Feb 09 16:55:36 2011, mrballcb wrote: Show quoted text
> Attached a patch which should strip values in parenthesis (but after the > transformation to underscores). It does not store the class of the > lookup (built-in or as-module). I feel it needs work and can possibly > be altered to just strip everything after ^lookup, for simplicity sake.
You have to click "Add More Files" for it to accept the current file you want to attach. :-)
Subject: test-mta-exim4.patch
--- Exim4.pm 2011-02-09 21:48:22.000000000 +0000 +++ /usr/lib/perl5/vendor_perl/5.8.8/Test/MTA/Exim4.pm 2011-02-09 21:49:11.000000000 +0000 @@ -530,7 +530,7 @@ elsif ( m{ ^ ( support \s+ for | # pick one of these - lookups | # in $1 + lookups \s+ [^:]+ | # in $1 authenticators | routers | transports @@ -544,6 +544,8 @@ my $type = lc($1); my $res = lc($2); $type =~ tr/a-z/_/cs; + $type =~ s/_built_in|_as_module//; # New lookup output format + $type =~ s/_$//; # strip trailing _ $type =~ s/s$//; # strip trailing s $res =~ tr|a-z0-9_ /||cd; my $table = { map { $_ => 1 } ( split( /[\s\/]/, $res ) ) };
Subject: More system info
From: tlyons [...] ivenue.com
On Wed Feb 09 16:55:36 2011, mrballcb wrote: Show quoted text
> The output of exim -bV has changed slightly WRT to lookups. Instead
This output change is with Exim 4.74. The additional lookups line output is Exim 4.74 patched with the lookups patch in bug 139, comment #26. I am using this on a CentOS 5.5 box, which uses perl 5.8.8 (stock distro provided version).
From: nigelm [...] cpan.org
Thanks for raising this. I'll look at this over the next few days (sorry - busy week), and push an update out by 18 Feb. Nigel.
Subject: Fixed in 0.04
Pushed a 0.04 release to CPAN today - this works for me... Let me know if this works correctly for you.
From: tlyons [...] ivenue.com
On Fri Feb 11 09:27:58 2011, NIGELM wrote: Show quoted text
> Pushed a 0.04 release to CPAN today - this works for me... > Let me know if this works correctly for you.
Verified proper operation with exim-4.74 and patched exim-4.74 with extra output. Suggest to close bug as resolved. Looked at the code change, very elegant patch, much nicer than what I had proposed, very nice! Thanks Nigel!