| Subject: | bug: impossible to use mode => "alpha-numerical" or mode => "numerical" |
| Date: | Tue, 08 Feb 2011 19:44:24 +0100 |
| To: | bug-Imager-QRCode [...] rt.cpan.org |
| From: | Christoph Bihler <christoph.bihler [...] br-online.de> |
hi,
when using
mode => "alpha-numerical"
or
mode => "numerical"
you'll get the following error:
Failed to encode the input data: XS error at
/usr/lib/perl5/site_perl/5.12.3/i486-linux-thread-multi/Imager/QRCode.pm
line 35.
in the routine responsible for handling these 2 modes, you're excluding
the valid modes by returning NULL if the valid modes are passed ;)
patch:
--- Imager-QRCode-0.033/src/qrencode.c 2011-01-16 16:45:45.000000000 +0100
+++ Imager-QRCode-0.033-lXTUfC/src/qrencode.c 2011-02-08
19:26:45.000000000 +0100
@@ -450,7 +450,7 @@
QRcode *code;
int ret;
- if(hint != QR_MODE_8 && hint != QR_MODE_KANJI) {
+ if(hint == QR_MODE_8 || hint == QR_MODE_KANJI) {
errno = EINVAL;
return NULL;
}
--
Christoph Bihler
Bayerischer Rundfunk
Multimedia und Jugend / BR-Online
Systemadministration
phone: +49-89-5900-16005
eMail: christoph.bihler@br-online.de
GPG-Fingerprint: 0BD4 F912 06EA E584 72D7 D48D 3F7F 3ABD D59E 82E6
Message body not shown because it is not plain text.