Bug #65527 for RPC-Serialized: Suppress sensitive arguments in log

Mon Feb 07 08:14:36 2011 dominic.hargreaves [...] oucs.ox.ac.uk - Ticket created

Subject:	Suppress sensitive arguments in log
Date:	Mon, 7 Feb 2011 13:14:26 +0000
To:	bug-RPC-Serialized [...] rt.cpan.org
From:	Dominic Hargreaves <dominic.hargreaves [...] oucs.ox.ac.uk>

Hello, You might like to include the attached patch, which allows the user to configure named arguments to suppress from the log (an obvious use case being passwords). There may be nicer ways to go about the data type mangling, but this worked for us. Cheers, Dominic. -- Dominic Hargreaves, Systems Development and Support Team Computing Services, University of Oxford

Message body is not shown because sender requested not to inline it.

Download signature.asc
application/pgp-signature 197b

Message body not shown because it is not plain text.

Mon Feb 07 08:15:33 2011 dom [...] cpan.org - Severity Wishlist added

Mon Feb 07 08:15:33 2011 dom [...] cpan.org - Broken in 0.0605 added

Wed Feb 16 17:22:04 2011 OLIVER [...] cpan.org - Correspondence added

Hi Dom, On Mon Feb 07 08:14:36 2011, dominic.hargreaves@oucs.ox.ac.uk wrote: Show quoted text

> You might like to include the attached patch, which allows the user > to configure named arguments to suppress from the log (an obvious > use case being passwords).

Many thanks for the feature patch. I've implemented this and shipped v1.110470 to CPAN, with one modification: The config parameter is a Hashref of Call => [args to filter] so that one can specify the args to filter on a per-Handler basis. I felt this would be safer because some Handlers might not be interpreting the args as a Hash and have coincidental arg values removed. Hope that makes sense :) -- regards, oliver.

Wed Feb 16 17:22:05 2011 The RT System itself - Status changed from 'new' to 'open'

Wed Feb 16 17:22:05 2011 OLIVER [...] cpan.org - Status changed from 'open' to 'resolved'

Thu Apr 14 09:18:36 2011 dominic.hargreaves [...] oucs.ox.ac.uk - Correspondence added

Subject:	Re: [rt.cpan.org #65527] Suppress sensitive arguments in log
Date:	Thu, 14 Apr 2011 14:18:26 +0100
To:	Oliver Gorwits via RT <bug-RPC-Serialized [...] rt.cpan.org>
From:	Dominic Hargreaves <dominic.hargreaves [...] oucs.ox.ac.uk>

On Wed, Feb 16, 2011 at 05:22:05PM -0500, Oliver Gorwits via RT wrote: Show quoted text

> On Mon Feb 07 08:14:36 2011, dominic.hargreaves@oucs.ox.ac.uk wrote:

> > You might like to include the attached patch, which allows the user > > to configure named arguments to suppress from the log (an obvious > > use case being passwords).

> > Many thanks for the feature patch. I've implemented this and shipped v1.110470 to CPAN, > with one modification: > > The config parameter is a Hashref of Call => [args to filter] so that one can specify the args > to filter on a per-Handler basis. I felt this would be safer because some Handlers might not > be interpreting the args as a Hash and have coincidental arg values removed. Hope that > makes sense :)

Great, thanks! Dominic. -- Dominic Hargreaves, Systems Development and Support Team Computing Services, University of Oxford

Download signature.asc
application/pgp-signature 198b

Message body not shown because it is not plain text.

Thu Apr 14 09:18:37 2011 The RT System itself - Status changed from 'resolved' to 'open'

Mon Apr 18 05:14:28 2011 OLIVER [...] cpan.org - Status changed from 'open' to 'resolved'