Skip Menu |

This queue is for tickets about the Sendmail-PMilter CPAN distribution.

Report information
The Basics
Id: 65499
Status: resolved
Priority: 0/
Queue: Sendmail-PMilter

People
Owner: Nobody in particular
Requestors: Daan [...] VEHosting.nl
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.98
Fixed in: 1.20_01



Hi, Sendmail::PMilter's "Context.pm" can't handle sendmail clients that connect over IPv6. As argument to 'SMFIC_CONNECT' sendmail passes the client's IPv6 address prepended by 'IPV6:', which Context.pm doesn't expect. The current code passes the client's address (including the 'IPV6:') directly to Socket6::inet_pton(), which can't handle it. The fix is a simple one-line patch that can be found here : http://vehosting.nl/pub_diffs/PMilter_Context.pm_ipv6_fix.diff This bug can be replicated on several systems, but at least on the following : OS: FreeBSD 8.0-STABLE Perl: 5.8.9 Sendmail: 8.14.4 Regards, Daan Vreeken - http://VEHosting.nl/
On 2011-02-06T10:05:49-05:00, Danovitsch wrote: Show quoted text
> Hi, > > Sendmail::PMilter's "Context.pm" can't handle sendmail clients that > connect over IPv6. As argument to 'SMFIC_CONNECT' sendmail passes the > client's IPv6 address prepended by 'IPV6:', which Context.pm doesn't > expect. The current code passes the client's address (including the > 'IPV6:') directly to Socket6::inet_pton(), which can't handle it. > > The fix is a simple one-line patch that can be found here : > http://vehosting.nl/pub_diffs/PMilter_Context.pm_ipv6_fix.diff > > > This bug can be replicated on several systems, but at least on the > following : > OS: FreeBSD 8.0-STABLE > Perl: 5.8.9 > Sendmail: 8.14.4 > > > Regards, > Daan Vreeken - http://VEHosting.nl/
Looks good, but grepping around in the sendmail sources it seems this can only be "IPv6:" as a prefix, not "IPV6:". I.e. the regex should be /^IPv6:/ not /^IPV6:/.
From: Daan [...] VEHosting.nl
Hi Arnfjord, On Sun Feb 06 11:11:32 2011, AVAR wrote: Show quoted text
> On 2011-02-06T10:05:49-05:00, Danovitsch wrote:
> > Hi, > > > > Sendmail::PMilter's "Context.pm" can't handle sendmail clients that > > connect over IPv6. As argument to 'SMFIC_CONNECT' sendmail passes the > > client's IPv6 address prepended by 'IPV6:', which Context.pm doesn't > > expect. The current code passes the client's address (including the > > 'IPV6:') directly to Socket6::inet_pton(), which can't handle it. > > > > The fix is a simple one-line patch that can be found here : > > http://vehosting.nl/pub_diffs/PMilter_Context.pm_ipv6_fix.diff > > > > > > This bug can be replicated on several systems, but at least on the > > following : > > OS: FreeBSD 8.0-STABLE > > Perl: 5.8.9 > > Sendmail: 8.14.4 > > > > > > Regards, > > Daan Vreeken - http://VEHosting.nl/
> > Looks good, but grepping around in the sendmail sources it seems this > can only be "IPv6:" as a prefix, not "IPV6:". I.e. the regex should be > /^IPv6:/ not /^IPV6:/.
The expression is case-insensitive (see the 'i' modifier at the end of the line), but you're right, sendmail prepends 'IPv6:' instead of 'IPV6:'. I've updated the diff file at the above URL.
Thanks. I've fixed this (and your regex to not use /i), committed it to Git[1], and released it as 0.99 on the CPAN. 1. https://github.com/avar/sendmail-pmilter/commit/0.99~1
Subject: Re: [rt.cpan.org #65499]
Date: Sun, 6 Feb 2011 22:53:56 +0100
To: bug-Sendmail-PMilter [...] rt.cpan.org
From: Daan Vreeken <Daan [...] vehosting.nl>
Hi, On Sunday 06 February 2011 22:39:31 AEvar Arnfjord Bjarmason via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=65499 > > > Thanks. I've fixed this (and your regex to not use /i), committed it to > Git[1], and released it as 0.99 on the CPAN. > > 1. https://github.com/avar/sendmail-pmilter/commit/0.99~1
Thanks for the quick fix! Regards, -- Daan Vreeken VEHosting http://VEHosting.nl tel: +31-(0)40-7113050 / +31-(0)6-46210825 KvK nr: 17174380