Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Test-Reporter CPAN distribution.

Report information
The Basics
Id: 6521
Status: resolved
Priority: 0/
Queue: Test-Reporter
People
Owner: RSOD [...] cpan.org
Requestors: rrwo [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Unimportant
Broken in: 1.20
Fixed in: (no value)

History Show all quoted text
  Fri Jun 04 15:17:27 2004 Guest - Ticket created
Subject: STYLE - globals should begin with caps
Global variables $dns, $domain, and $send should begin with caps so as to conform to standard coding practives and make modules easier to debug. Names like $Dns, $Domain, and $Send would be clear that they are global variables. Better yet, more descriptive names like $HasMailSendModule instead of $send.
  Mon Jun 07 03:30:59 2004 FOX [...] cpan.org - Correspondence added
[guest - Fri Jun 4 15:17:27 2004]: Show quoted text
> Global variables $dns, $domain, and $send should begin with caps so as > to conform to standard coding practives and make modules easier to > debug. Names like $Dns, $Domain, and $Send would be clear that > they are global variables. > > Better yet, more descriptive names like $HasMailSendModule instead of > $send.
Hm. I quote: use vars qw($VERSION $AUTOLOAD $fh $Report $MacMPW $MacApp $dns $domain $send); Looks like I did miss a few. Will be corrected in next version. However, I'd like to point out that you're teetering on the edge of being patronizing. It'd probably have been better taken to give a gentle oh-hey-you-missed-a-few to a 20-year veteran rather than a lesson. :-)
  Mon Jun 07 03:31:00 2004 FOX [...] cpan.org - Status changed from 'new' to 'resolved'
  Mon Jun 07 10:00:10 2004 Guest - Correspondence added
From: rrwo [...] cpan.org
[FOX - Mon Jun 7 03:30:59 2004]: Show quoted text
> However, I'd like to point out that you're teetering on the edge of > being patronizing. It'd > probably have been better taken to give a gentle oh-hey-you-missed-a- > few to a 20-year > veteran rather than a lesson. :-)
Didn't mean to be patronizing. Just the result of working all night. Thanks.
  Mon Jun 07 10:00:13 2004 The RT System itself - Status changed from 'resolved' to 'open'
  Sun Dec 26 13:31:41 2004 RSOD [...] cpan.org - Correspondence added
[guest - Fri Jun 4 15:17:27 2004]: Show quoted text
> Global variables $dns, $domain, and $send should begin with caps so as > to conform to standard coding practives and make modules easier to > debug. Names like $Dns, $Domain, and $Send would be clear that > they are global variables.
I've ucfirst'd the remaining globals that were lowercased, as of 1.23. - R.
  Sun Dec 26 13:32:43 2004 RSOD [...] cpan.org - Requestor RSOD added
  Thu Jan 06 00:32:44 2005 RSOD [...] cpan.org - Status changed from 'open' to 'resolved'
  Thu Jan 06 00:38:17 2005 RSOD [...] cpan.org - Requestor RSOD deleted
  Thu Jan 06 00:38:17 2005 RSOD [...] cpan.org - Given to RSOD