Skip Menu |

This queue is for tickets about the POE-Component-Resolver CPAN distribution.

Report information
The Basics
Id: 65179
Status: resolved
Priority: 0/
Queue: POE-Component-Resolver

People
Owner: Nobody in particular
Requestors: SAPER [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.900
Fixed in: (no value)



Subject: [patch] fix for Perl 5.8
Hello, As promised, the (very small) patch to make PoCo-Resolver work on Perl 5.8 Tests pass with some warnings: $ perl -Ilib t/01-basic.t 1..4 # ipv6-test.com = 2001:41d0:2:67d1::7e57:1 ok 1 - address families are as expected (10) # ipv6-test.com = 178.32.99.36 ok 2 - address families are as expected (2) # ipv6-test.com = 178.32.99.36 # ipv6-test.com = 2001:41d0:2:67d1::7e57:1 ok 3 - address families are as expected (2 10) # ipv6-test.com = 2001:41d0:2:67d1::7e57:1 # ipv6-test.com = 178.32.99.36 ok 4 - address families are as expected (10 2) <rv> session not resolved: No such process at lib/POE/Component/ Resolver.pm line 77 POE::Component::Resolver::DESTROY('POE::Component::Resolver=HASH (0xcd7c70)') called at t/01-basic.t line 0 eval {...} called at t/01-basic.t line 0 <rv> session not resolved: No such process at lib/POE/Component/ Resolver.pm line 77 POE::Component::Resolver::DESTROY('POE::Component::Resolver=HASH (0xcaa330)') called at t/01-basic.t line 0 eval {...} called at t/01-basic.t line 0 <rv> session not resolved: No such process at lib/POE/Component/ Resolver.pm line 77 POE::Component::Resolver::DESTROY('POE::Component::Resolver=HASH (0xb25dc0)') called at t/01-basic.t line 0 eval {...} called at t/01-basic.t line 0 <rv> session not resolved: No such process at lib/POE/Component/ Resolver.pm line 77 POE::Component::Resolver::DESTROY('POE::Component::Resolver=HASH (0xcd7c40)') called at t/01-basic.t line 0 eval {...} called at t/01-basic.t line 0 HTH -- Close the world, txEn eht nepO.
Subject: poe-component-resolver-0.900-perl5.8.diff
diff --git a/lib/POE/Component/Resolver.pm b/lib/POE/Component/Resolver.pm index 9722b46..fdd9052 100644 --- a/lib/POE/Component/Resolver.pm +++ b/lib/POE/Component/Resolver.pm @@ -290,10 +290,10 @@ sub resolve { ); my $misc = delete $args{misc}; - $misc //= ""; + $misc ||= ""; my $hints = delete $args{hints}; - $hints //= { }; + $hints ||= { }; my $event = delete $args{event}; $event = "resolver_response" unless defined $event and length $event;
Thank you for the patch. I've applied and committed it. Also thank you for the warning about the warnings. :) They're fixed in the repository, and they'll be gone after from the next release.