Skip Menu |

This queue is for tickets about the Perl-Critic-PetPeeves-JTRAMMELL CPAN distribution.

Report information
The Basics
Id: 65153
Status: resolved
Worked: 2 hours (120 min)
Priority: 0/
Queue: Perl-Critic-PetPeeves-JTRAMMELL
People
Owner: johntrammell [...] gmail.com
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.01
Fixed in: (no value)

History Show all quoted text
  Wed Jan 26 09:47:12 2011 ppisar [...] redhat.com - Ticket created
Subject: Missing depenedecies in META.yml
META.yml/Build.PL does not list following dependencies: requires: Data::Dumper build_requires: Data::Dumper Perl::Critic::Config optional build_requires: Test::Pod 1.14 Test::Pod::Coverage 1.04
  Wed Jan 26 14:43:54 2011 johntrammell [...] gmail.com - Correspondence added
From: johntrammell [...] gmail.com
Data::Dumper is used in some example code in etc/, and is not required to build, install, or use the package.
  Wed Jan 26 14:43:54 2011 The RT System itself - Status changed from 'new' to 'open'
  Thu Jan 27 04:43:18 2011 ppisar [...] redhat.com - Correspondence added
Subject: Re: [rt.cpan.org #65153] Missing depenedecies in META.yml
Date: Thu, 27 Jan 2011 10:43:04 +0100
To: "John J. Trammell via RT" <bug-Perl-Critic-PetPeeves-JTRAMMELL [...] rt.cpan.org>
From: Petr Pisar <ppisar [...] redhat.com>
On Wed, Jan 26, 2011 at 02:43:54PM -0500, John J. Trammell via RT wrote: Show quoted text
> Data::Dumper is used in some example code in etc/, and is not required > to build, install, or use the package. >
Indeed?: lib/Perl/Critic/Policy/Variables/ProhibitUselessInitialization.pm:9 $ strace -fq -eopen make test 2>&1 |grep ProhibitUselessInitialization [pid 8433] open("/tmp/Perl-Critic-PetPeeves-JTRAMMELL-0.01/blib/lib/Perl/Critic/Policy/Variables/ProhibitUselessInitialization.pm", O_RDONLY) = 3 [...] -- Petr
  Thu Jan 27 15:23:57 2011 johntrammell [...] gmail.com - Correspondence added
On Thu Jan 27 04:43:18 2011, ppisar wrote: Show quoted text
> On Wed, Jan 26, 2011 at 02:43:54PM -0500, John J. Trammell via RT > wrote:
> > Data::Dumper is used in some example code in etc/, and is not
> required
> > to build, install, or use the package. > >
> Indeed?: > lib/Perl/Critic/Policy/Variables/ProhibitUselessInitialization.pm:9 > > $ strace -fq -eopen make test 2>&1 |grep ProhibitUselessInitialization > [pid 8433] > open("/tmp/Perl-Critic-PetPeeves-JTRAMMELL- >
0.01/blib/lib/Perl/Critic/Policy/Variables/ProhibitUselessInitialization.pm", Show quoted text
> O_RDONLY) = 3 > [...]
Interesting, the version I have locally does not have Data::Dumper. I'll be releasing an update shortly. Not sure what the grep is supposed to tell me; care to elaborate?
  Fri Jan 28 03:30:41 2011 ppisar [...] redhat.com - Correspondence added
Subject: Re: [rt.cpan.org #65153] Missing depenedecies in META.yml
Date: Fri, 28 Jan 2011 09:30:24 +0100
To: "John J. Trammell via RT" <bug-Perl-Critic-PetPeeves-JTRAMMELL [...] rt.cpan.org>
From: Petr Pisar <ppisar [...] redhat.com>
On Thu, Jan 27, 2011 at 03:23:58PM -0500, John J. Trammell via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=65153 > > > On Thu Jan 27 04:43:18 2011, ppisar wrote:
> > On Wed, Jan 26, 2011 at 02:43:54PM -0500, John J. Trammell via RT > > wrote:
> > > Data::Dumper is used in some example code in etc/, and is not
> > required
> > > to build, install, or use the package. > > >
> > Indeed?: > > lib/Perl/Critic/Policy/Variables/ProhibitUselessInitialization.pm:9 > > > > $ strace -fq -eopen make test 2>&1 |grep ProhibitUselessInitialization > > [pid 8433] > > open("/tmp/Perl-Critic-PetPeeves-JTRAMMELL- > >
> 0.01/blib/lib/Perl/Critic/Policy/Variables/ProhibitUselessInitialization.pm",
> > O_RDONLY) = 3 > > [...]
> > Interesting, the version I have locally does not have Data::Dumper. > I'll be releasing an update shortly. > > Not sure what the grep is supposed to tell me; care to elaborate?
To show the ProhibitUselessInitialization.pm is load at test time. And because line 9 uses Data::Dumper, the Data::Dumper is build and run time dependency. Showing Dumper.pm in strace output is useless as the module is load before ProhibitUselessInitialization.pm for other reason. -- Petr
  Fri Jan 28 09:17:27 2011 johntrammell [...] gmail.com - Correspondence added 120 min
Changes: * moved from Google Code to Github * fixed dependencies
  Fri Jan 28 09:17:28 2011 johntrammell [...] gmail.com - Status changed from 'open' to 'resolved'
  Fri Jan 28 09:17:28 2011 johntrammell [...] gmail.com - Given to JTRAMMELL