| Subject: | Errors in strict mode |
In Net::DBus, in strict mode when calling a method without an interface specified, we get:
Use of uninitialized value $interface in string eq at /usr/local/lib64/perl5/Net/DBus/Object.pm line
476.
Use of uninitialized value $interface in string eq at /usr/local/lib64/perl5/Net/DBus/Object.pm line
485.
Attached patch fixes the problem.
| Subject: | fix-strict-mode-errors.patch |
# HG changeset patch
# User Mathieu Bridon <mathieu.bridon@network-box.com>
# Date 1295863011 -28800
# Node ID 98165f54d33ea84ebc2bd9bf9973a2113cfb1b73
# Parent 250aa735fec012674b059113bb1f2075633d78ea
Fix strict mode errors.
diff -r 250aa735fec0 -r 98165f54d33e lib/Net/DBus/Object.pm
--- a/lib/Net/DBus/Object.pm Fri May 07 11:19:30 2010 +0100
+++ b/lib/Net/DBus/Object.pm Mon Jan 24 17:56:51 2011 +0800
@@ -473,7 +473,7 @@
my $reply;
my $method_name = $message->get_member;
my $interface = $message->get_interface;
- if ($interface eq "org.freedesktop.DBus.Introspectable") {
+ if ((defined $interface)&&($interface eq "org.freedesktop.DBus.Introspectable")) {
if ($method_name eq "Introspect" &&
$self->_introspector &&
$ENABLE_INTROSPECT) {
@@ -482,7 +482,7 @@
$self->_introspector->encode($reply, "methods", $method_name, "returns", $xml);
}
- } elsif ($interface eq "org.freedesktop.DBus.Properties") {
+ } elsif ((defined $interface)&&($interface eq "org.freedesktop.DBus.Properties")) {
if ($method_name eq "Get") {
$reply = $self->_dispatch_prop_read($connection, $message);
} elsif ($method_name eq "Set") {