Skip Menu |

This queue is for tickets about the CDB_File CPAN distribution.

Report information
The Basics
Id: 64981
Status: resolved
Priority: 0/
Queue: CDB_File
People
Owner: Nobody in particular
Requestors: HMBRAND [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 0.96
Fixed in: 0.97

History Show all quoted text
  Fri Jan 21 07:08:31 2011 HMBRAND [...] cpan.org - Ticket created
Subject: ppport.h is a bit out of date - should require 5.8.0
"ppport.h", line 2979: warning #2047-D: incompatible redefinition of macro "PERL_UNUSED_DECL" (declared at line 330 of "/pro/lib/perl5/5.10.1/IA64.ARCHREV_0-LP64/CORE/perl.h") # define PERL_UNUSED_DECL ^ With ppport-3.19, that warning disappears $ perl ppport.h Scanning ./CDB_File.xs ... === Analyzing ./CDB_File.xs === Uses PL_na Uses newSVpvn, which depends on newSV, newSVpv *** WARNING: Uses PerlIO_close, which may not be portable below perl 5.7.3, even with 'ppport.h' *** WARNING: Uses PerlIO_fileno, which may not be portable below perl 5.7.3, even with 'ppport.h' *** WARNING: Uses PerlIO_flush, which may not be portable below perl 5.7.3, even with 'ppport.h' *** WARNING: Uses PerlIO_read, which may not be portable below perl 5.7.3, even with 'ppport.h' *** WARNING: Uses PerlIO_seek, which may not be portable below perl 5.7.3, even with 'ppport.h' *** WARNING: Uses PerlIO_write, which may not be portable below perl 5.7.3, even with 'ppport.h' Analysis completed (6 warnings) Looks good $ perl ppport.h --compat-v ersion=5.8.0 Scanning ./CDB_File.xs ... === Analyzing ./CDB_File.xs === No need to include 'ppport.h' Analysis completed Suggested changes: --- ./CDB_File.xs 2008-03-21 16:40:57 +0100 +++ ./CDB_File.xs.patched 2011-01-21 13:06:23 +0100 @@ -36,7 +36,6 @@ #include "EXTERN.h" #include "perl.h" #include "XSUB.h" -#include "ppport.h" #include <sys/stat.h> #include <sys/types.h>
  Fri Apr 01 13:52:47 2011 TODDR [...] cpan.org - Correspondence added
Actually, according to ppport.h, the file should not be shipped at all: $>perl ppport.h --compat-version=5.6 Scanning ./CDB_File.xs ... === Analyzing ./CDB_File.xs === No need to include 'ppport.h' Suggested changes: --- ./CDB_File.xs +++ ./CDB_File.xs.patched @@ -36,7 +36,6 @@ #include "EXTERN.h" #include "perl.h" #include "XSUB.h" -#include "ppport.h" #include <sys/stat.h> #include <sys/types.h>
  Fri Apr 01 13:52:47 2011 The RT System itself - Status changed from 'new' to 'open'
  Fri Apr 01 13:55:56 2011 TODDR [...] cpan.org - Correspondence added
I'm working on a dev release proposal: https://github.com/toddr/CDB_File/commit/8fd1bbaf6a1b85e146594e3cfda561d528151275
  Mon Apr 04 02:22:45 2011 h.m.brand [...] xs4all.nl - Correspondence added
Subject: Re: [rt.cpan.org #64981] ppport.h is a bit out of date - should require 5.8.0
Date: Mon, 4 Apr 2011 08:22:27 +0200
To: bug-CDB_File [...] rt.cpan.org
From: "H.Merijn Brand" <h.m.brand [...] xs4all.nl>
On Fri, 1 Apr 2011 13:52:47 -0400, "Todd Rinaldo via RT" <bug-CDB_File@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=64981 > > > Actually, according to ppport.h, the file should not be shipped at all:
According to the manual, it should: How to use ppport.h Don't direct the users of your module to download "Devel::PPPort". They are most probably no XS writers. Also, don't make ppport.h optional. Rather, just take the most recent copy of ppport.h that you can find (e.g. by generating it with the latest "Devel::PPPort" release from CPAN), copy it into your project, adjust your project to use it, and distribute the header along with your module. As a pro to "ship it", there is DBI, that ships it in a renamed file, so the DBI maintainers know exactly what to expect. Just my € 0.02 Show quoted text
> $>perl ppport.h --compat-version=5.6 > Scanning ./CDB_File.xs ... > === Analyzing ./CDB_File.xs === > No need to include 'ppport.h' > Suggested changes: > --- ./CDB_File.xs > +++ ./CDB_File.xs.patched > @@ -36,7 +36,6 @@ > #include "EXTERN.h" > #include "perl.h" > #include "XSUB.h" > -#include "ppport.h" > > #include <sys/stat.h> > #include <sys/types.h> >
-- H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ using 5.00307 through 5.12 and porting perl5.13.x on HP-UX 10.20, 11.00, 11.11, 11.23 and 11.31, OpenSuSE 10.1, 11.0 .. 11.3 and AIX 5.2 and 5.3. http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/
  Tue Apr 05 19:20:37 2011 TODDR [...] cpan.org - Correspondence added
RT-Send-CC: h.m.brand [...] xs4all.nl
Right you are! Sorry, I missed the RT update before updating the module. I've released 0.97_01 to pause. I'll have 0.98 out by the end of the week if there are no issues.
  Tue Apr 05 19:22:56 2011 TODDR [...] cpan.org - Status changed from 'open' to 'patched'
  Tue Apr 05 19:45:31 2011 TODDR [...] cpan.org - Correspondence added
RT-Send-CC: h.m.brand [...] xs4all.nl
ok, I looked closer at this... Show quoted text
> According to the manual, it should: > > How to use ppport.h > Don't direct the users of your module to download > "Devel::PPPort". > They are most probably no XS writers. Also, don't make ppport.h > optional. Rather, just take the most recent copy of ppport.h > that you > can find (e.g. by generating it with the latest "Devel::PPPort" > release > from CPAN), copy it into your project, adjust your project to > use it, > and distribute the header along with your module.
Yes but I don't need it at all. When I run the latest ppport.h, requiring 5.6, I get this: $>perl ppport.h --compat-version=5.6.2 Scanning ./CDB_File.xs ... === Analyzing ./CDB_File.xs === *** WARNING: Uses PerlIO_close, which may not be portable below perl 5.7.3, even with 'ppport.h' *** WARNING: Uses PerlIO_fileno, which may not be portable below perl 5.7.3, even with 'ppport.h' *** WARNING: Uses PerlIO_flush, which may not be portable below perl 5.7.3, even with 'ppport.h' *** WARNING: Uses PerlIO_read, which may not be portable below perl 5.7.3, even with 'ppport.h' *** WARNING: Uses PerlIO_seek, which may not be portable below perl 5.7.3, even with 'ppport.h' *** WARNING: Uses PerlIO_write, which may not be portable below perl 5.7.3, even with 'ppport.h' No need to include 'ppport.h' Analysis completed (6 warnings) Suggested changes: --- ./CDB_File.xs +++ ./CDB_File.xs.patched @@ -36,7 +36,6 @@ #include "EXTERN.h" #include "perl.h" #include "XSUB.h" -#include "ppport.h" #include <sys/stat.h> #include <sys/types.h> So even though they warn about 5.6 compatibility, they're still recommending I not include it at all... Do you disagree?
  Tue Apr 05 19:45:33 2011 The RT System itself - Status changed from 'patched' to 'open'
  Wed Apr 06 02:04:17 2011 h.m.brand [...] xs4all.nl - Correspondence added
Subject: Re: [rt.cpan.org #64981] ppport.h is a bit out of date - should require 5.8.0
Date: Wed, 6 Apr 2011 08:04:03 +0200
To: bug-CDB_File [...] rt.cpan.org
From: "H.Merijn Brand" <h.m.brand [...] xs4all.nl>
On Tue, 5 Apr 2011 19:45:33 -0400, "Todd Rinaldo via RT" <bug-CDB_File@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=64981 > > > ok, I looked closer at this... >
> > According to the manual, it should: > > > > How to use ppport.h > > Don't direct the users of your module to download > > "Devel::PPPort". > > They are most probably no XS writers. Also, don't make ppport.h > > optional. Rather, just take the most recent copy of ppport.h > > that you > > can find (e.g. by generating it with the latest "Devel::PPPort" > > release > > from CPAN), copy it into your project, adjust your project to > > use it, > > and distribute the header along with your module.
> > Yes but I don't need it at all. When I run the latest ppport.h, requiring 5.6, I get this: > > $>perl ppport.h --compat-version=5.6.2 > Scanning ./CDB_File.xs ... > === Analyzing ./CDB_File.xs === > *** WARNING: Uses PerlIO_close, which may not be portable below perl 5.7.3, even with > 'ppport.h' > *** WARNING: Uses PerlIO_fileno, which may not be portable below perl 5.7.3, even with > 'ppport.h' > *** WARNING: Uses PerlIO_flush, which may not be portable below perl 5.7.3, even with > 'ppport.h' > *** WARNING: Uses PerlIO_read, which may not be portable below perl 5.7.3, even with > 'ppport.h' > *** WARNING: Uses PerlIO_seek, which may not be portable below perl 5.7.3, even with > 'ppport.h' > *** WARNING: Uses PerlIO_write, which may not be portable below perl 5.7.3, even with > 'ppport.h' > No need to include 'ppport.h' > Analysis completed (6 warnings) > Suggested changes: > --- ./CDB_File.xs > +++ ./CDB_File.xs.patched > @@ -36,7 +36,6 @@ > #include "EXTERN.h" > #include "perl.h" > #include "XSUB.h" > -#include "ppport.h" > > #include <sys/stat.h> > #include <sys/types.h> > > > > So even though they warn about 5.6 compatibility, they're still recommending I not include it > at all... > > Do you disagree?
No. Then you can safely drop it :) -- H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ using 5.00307 through 5.12 and porting perl5.13.x on HP-UX 10.20, 11.00, 11.11, 11.23 and 11.31, OpenSuSE 10.1, 11.0 .. 11.3 and AIX 5.2 and 5.3. http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/
  Wed Apr 06 12:00:09 2011 TODDR [...] cpan.org - Fixed in 0.97 added
  Wed Apr 06 12:00:16 2011 TODDR [...] cpan.org - Status changed from 'open' to 'resolved'