Skip Menu |

This queue is for tickets about the JavaScript-Minifier-XS CPAN distribution.

Report information
The Basics
Id: 64948
Status: resolved
Priority: 0/
Queue: JavaScript-Minifier-XS

People
Owner: Nobody in particular
Requestors: RUZ [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.09
Fixed in: 0.10



Subject: support older perls with ppport.h
Hello, I would love to see perl 5.8.3 suported at least. Here is output from ppport.h run. Patch attached. Scanning ./XS.xs ... === Analyzing ./XS.xs === Uses Newxz Uses PL_sv_undef Needs to include 'ppport.h' *** Uses 3 C++ style comments, which is not portable Analysis completed To include ppport.h into distribution, just install Devel::PPPort and run the following command to generate the h file: perl -MDevel::PPPort -e 'Devel::PPPort::WriteFile();' -- Best regards, Ruslan.
Subject: JavaScript-Minifier-XS-0.09-use_ppport_to_support_older_perls.patch
--- ./XS.xs +++ ./XS.xs.patched @@ -1,6 +1,7 @@ #include <EXTERN.h> #include <perl.h> #include <XSUB.h> +#include "ppport.h" #include <string.h> #include <strings.h> @@ -8,7 +9,7 @@ #include <ctype.h> /* uncomment to enable debugging output */ -//#define DEBUG 1 +/*#define DEBUG 1 */ /* **************************************************************************** * CHARACTER CLASS METHODS @@ -194,7 +195,7 @@ * **************************************************************************** */ /* allocates a new node */ -static size_t js_id_counter=0; // XXX +static size_t js_id_counter=0; /* XXX */ Node* JsAllocNode() { Node* node; Newxz(node, 1, Node); @@ -203,7 +204,7 @@ node->contents = NULL; node->length = 0; node->type = NODE_EMPTY; - node->id = js_id_counter++; // XXX + node->id = js_id_counter++; /* XXX */ return node; }