Skip Menu |

This queue is for tickets about the DBIx-Class-Schema-Loader CPAN distribution.

Report information
The Basics
Id: 64820
Status: resolved
Priority: 0/
Queue: DBIx-Class-Schema-Loader

People
Owner: Nobody in particular
Requestors: david.storrs [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Wishlist: make datetime_undef_if_invalid => 1 the default in MySQL
Date: Sat, 15 Jan 2011 22:28:28 -0800
To: bug-DBIx-Class-Schema-Loader [...] rt.cpan.org
From: David Storrs <david.storrs [...] gmail.com>
Would it be possible to make DATE columns automatically contain datetime_undef_if_invalid => 1 for MySQL when the column is nullable? Currently this attribute is not included, which causes a lot of exceptions in what should be valid records. Dave Storrs
Subject: Re: [rt.cpan.org #64820] Wishlist: make datetime_undef_if_invalid => 1 the default in MySQL
Date: Sun, 16 Jan 2011 01:47:33 -0500
To: bug-DBIx-Class-Schema-Loader [...] rt.cpan.org
From: Rafael Kitover <rkitover [...] cpan.org>
After some further discussion on #dbix-class, we'll do this: For DATE and TIMESTAMP columns in MySQL, set "datetime_undef_if_invalid => 1" for both nullable and NOT NULL columns. This will be done in the next version, which I'm planning in hopefully not more than a month. Any objections? On 1/16/2011 1:28 AM, David Storrs via RT wrote: Show quoted text
> Sun Jan 16 01:28:37 2011: Request 64820 was acted upon. > Transaction: Ticket created by david.storrs@gmail.com > Queue: DBIx-Class-Schema-Loader > Subject: Wishlist: make datetime_undef_if_invalid => 1 the default in MySQL > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: david.storrs@gmail.com > Status: new > Ticket<URL: https://rt.cpan.org/Ticket/Display.html?id=64820> > > > Would it be possible to make DATE columns automatically contain > datetime_undef_if_invalid => 1 for MySQL when the column is nullable? > Currently this attribute is not included, which causes a lot of > exceptions in what should be valid records. > > Dave Storrs >
Subject: Re: [rt.cpan.org #64820] Wishlist: make datetime_undef_if_invalid => 1 the default in MySQL
Date: Sat, 15 Jan 2011 23:02:48 -0800
To: bug-DBIx-Class-Schema-Loader [...] rt.cpan.org
From: David Storrs <david.storrs [...] gmail.com>
On Sat, Jan 15, 2011 at 10:48 PM, rkitover@cpan.org via RT <bug-DBIx-Class-Schema-Loader@rt.cpan.org> wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=64820 > > > After some further discussion on #dbix-class, we'll do this: > > For DATE and TIMESTAMP columns in MySQL, set > "datetime_undef_if_invalid => 1" > for both nullable and NOT NULL columns. > > This will be done in the next version, which I'm planning in hopefully > not more than a month. > > Any objections?
Sounds great to me -- more than I asked for, in fact. Show quoted text
> > On 1/16/2011 1:28 AM, David Storrs via RT wrote:
>> Sun Jan 16 01:28:37 2011: Request 64820 was acted upon. >> Transaction: Ticket created by david.storrs@gmail.com >>         Queue: DBIx-Class-Schema-Loader >>       Subject: Wishlist: make datetime_undef_if_invalid =>  1 the default in MySQL >>     Broken in: (no value) >>      Severity: (no value) >>         Owner: Nobody >>    Requestors: david.storrs@gmail.com >>        Status: new >>   Ticket<URL: https://rt.cpan.org/Ticket/Display.html?id=64820> >> >> >> Would it be possible to make DATE columns automatically contain >> datetime_undef_if_invalid =>  1 for MySQL when the column is nullable? >> Currently this attribute is not included, which causes a lot of >> exceptions in what should be valid records. >> >> Dave Storrs >>
> >
Fixed in git for DATE, DATETIME and TIMESTAMP data types. git://git.shadowcat.co.uk/dbsrgits/DBIx-Class-Schema-Loader.git