Skip Menu |

This queue is for tickets about the Filesys-SmbClient CPAN distribution.

Report information
The Basics
Id: 64774
Status: open
Priority: 0/
Queue: Filesys-SmbClient

People
Owner: Nobody in particular
Requestors: RWSTAUNER [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 3.1
Fixed in: (no value)



Subject: t/02tie.t tests skipped != test planned
t/02tie.t plans 25 tests, but the SKIP block (which contains 25 tests) only declares to be skipping 20, so the test fails. in order to install the module I had to edit the test file to skip 25.
Attached is a patch to fix it. On Fri Jan 14 08:25:28 2011, RWSTAUNER wrote: Show quoted text
> t/02tie.t plans 25 tests, > but the SKIP block (which contains 25 tests) > only declares to be skipping 20, > so the test fails. > > in order to install the module I had to edit the test file to skip 25.
Subject: 02tie.patch
diff --git a/t/02tie.t b/t/02tie.t index b1ad8d3..9ddfb96 100755 --- a/t/02tie.t +++ b/t/02tie.t @@ -8,13 +8,15 @@ use File::Copy; use POSIX; use Config; +my $tests = 25; + if( !$Config{'PERL_API_REVISION'} or !$Config{'PERL_VERSION'} or ($Config{'PERL_API_REVISION'} != 5 or $Config{PERL_VERSION}<6)) { plan skip_all => 'tie filehandle for Filesys::SmbClient didn\'t work before Perl 5.6'; } else { - plan tests => 25; + plan tests => $tests; } require Filesys::SmbClient; @@ -23,7 +25,7 @@ my $buffer = "A test of write call\n"; my $buffer2 = "buffer of 1234\n"; SKIP: { - skip "No server defined for test at perl Makefile.PL", 20 if (!-e ".c"); + skip "No server defined for test at perl Makefile.PL", $tests if (!-e ".c"); my $ok = 0; my (%param,$server); if (open(F,".c")) {