| Subject: | [PATCH] URI escaping of '+' |
Maintainer: Many thanks to Sebastian Utz <su@rotamente.com> who wrote
"Hello Murat,
at first, thank you for the nice Winamp::Control package, works easy and
great!
Because I've got some problems with spaces at filenames(spaces was
translated to '+' characters), i dived into your code and found the
problem.
The '$uri->query_form()' function from the URI packages seems to
translate the 'spaces' wrong!
So I didn't wanted to dive into the URI source-code too, i did an
work-around at your 'Control.pm' to fix this.
(using '$uri->query()' with joined args instead)
I hope I was right and if so I wanted to publish the fix to the
community, so I send you this mail..
nice greetings
sebastian"
--- /usr/local/share/perl/5.8.4/Winamp/Control.pm 2004-05-26 23:31:59.000000000 +0200
+++ Control.pm 2004-05-27 20:03:52.000000000 +0200
@@ -66,10 +66,12 @@
$uri->path( $func );
- $uri->query_form( @args );
+ #$uri->query_form( @args );
+ my @query;
+ for (my $i=0;$i<=$#args;$i++) { push @query, $args[$i] . "=" . $args[$i+1]; $i++;}
+ $uri->query( join('&', @query) );
#$uri->userinfo( 'user:pw' );
-
warn $uri->as_string, "\n" if $main::opts{debug};