Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Git-Wrapper CPAN distribution.

Report information
The Basics
Id: 64665
Status: open
Priority: 0/
Queue: Git-Wrapper
People
Owner: GENEHACK [...] cpan.org
Requestors:
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.014
Fixed in: (no value)

History Show all quoted text
  Mon Jan 10 18:24:59 2011 ilmari.vacklin [...] cs.helsinki.fi - Ticket created
Subject: log() doesn't support arbitrary formats
Calling $git->log({ format => "format:%ai%n %s" }, ...), for an example, dies on line 112 of Wrapper.pm because the format doesn't include the "commit <hash>" line, which the log method expects to see. I'm unsure if we want to have Log objects without the id hashes around. If not, I didn't see an obvious fix.
  Fri Jul 08 22:53:36 2011 GENEHACK [...] cpan.org - Taken
  Fri Jul 08 22:54:59 2011 GENEHACK [...] cpan.org - Correspondence added
On Mon Jan 10 18:24:59 2011, ilmari.vacklin@cs.helsinki.fi wrote: Show quoted text
> Calling $git->log({ format => "format:%ai%n %s" }, ...), for an example, > dies on line 112 of Wrapper.pm because the format doesn't include the > "commit <hash>" line, which the log method expects to see. > > I'm unsure if we want to have Log objects without the id hashes around. If > not, I didn't see an obvious fix.
Thanks for the bug report. Could you give me a better idea of why you'd want to do this? My initial inclination is just to strip out a 'format' option that's passed to the log() method... thanks, john.
  Fri Jul 08 22:55:00 2011 The RT System itself - Status changed from 'new' to 'open'
  Tue Sep 13 07:42:04 2011 GENEHACK [...] cpan.org - Correspondence added
On Fri Jul 08 22:54:59 2011, GENEHACK wrote: Show quoted text
> On Mon Jan 10 18:24:59 2011, ilmari.vacklin@cs.helsinki.fi wrote:
> > Calling $git->log({ format => "format:%ai%n %s" }, ...), for an
> example,
> > dies on line 112 of Wrapper.pm because the format doesn't include
> the
> > "commit <hash>" line, which the log method expects to see. > > > > I'm unsure if we want to have Log objects without the id hashes
> around. If
> > not, I didn't see an obvious fix.
> > Thanks for the bug report. > > Could you give me a better idea of why you'd want to do this? My > initial inclination is just to > strip out a 'format' option that's passed to the log() method...
ping
  Sun Apr 22 13:41:52 2012 GENEHACK [...] cpan.org - Correspondence added
On Tue Sep 13 07:42:04 2011, GENEHACK wrote: Show quoted text
> On Fri Jul 08 22:54:59 2011, GENEHACK wrote:
> > On Mon Jan 10 18:24:59 2011, ilmari.vacklin@cs.helsinki.fi wrote:
> > > Calling $git->log({ format => "format:%ai%n %s" }, ...), for an
> > example,
> > > dies on line 112 of Wrapper.pm because the format doesn't include
> > the
> > > "commit <hash>" line, which the log method expects to see. > > > > > > I'm unsure if we want to have Log objects without the id hashes
> > around. If
> > > not, I didn't see an obvious fix.
> > > > Thanks for the bug report. > > > > Could you give me a better idea of why you'd want to do this? My > > initial inclination is just to > > strip out a 'format' option that's passed to the log() method...
>
Ticket closed due to lack of response. thanks, john.
  Sun Apr 22 13:41:53 2012 GENEHACK [...] cpan.org - Status changed from 'open' to 'resolved'
  Fri Oct 25 08:48:54 2013 BBYRD [...] cpan.org - Correspondence added
RT-Send-CC: ilmari.vacklin [...] cs.helsinki.fi, perlkat [...] katspace.org
On Fri Jul 08 22:54:59 2011, GENEHACK wrote: Show quoted text
> Could you give me a better idea of why you'd want to do this? My > initial inclination is just to > strip out a 'format' option that's passed to the log() method...
Hi. I found this ticket number buried in the git log of Dist::Zilla::Plugin::GitFmtChanges in reference to this line: open my $commit, "-|", "git log --format=\"$log_format\" $tags[$i-1]{tag}..$tags[$i]{tag} ." or die $!; I was actually investigating why Git::Wrapper wasn't being used here. The git log entry for this line was: Use Git::Wrapper for the operations we can. This makes the module work on Win32. See Git::Wrapper RT #64665 for more information on why we can't use Git::Wrapper for all operations. So, maybe this is the example you were looking for. CCing repo maintainer and patch author.
  Mon Dec 16 20:44:01 2013 GENEHACK [...] cpan.org - Correspondence added
RT-Send-CC: perlkat [...] katspace.org, ilmari.vacklin [...] cs.helsinki.fi
Re-opening ticket. The only sane way I see of supporting this is, if a format argument is detected, don't attempt any parsing of the log. I guess I can implement that over the upcoming holiday, unless somebody wants to beat me too it.
  Mon Dec 16 20:44:02 2013 GENEHACK [...] cpan.org - Status changed from 'resolved' to 'open'