Skip Menu |

This queue is for tickets about the Encode CPAN distribution.

Report information
The Basics
Id: 64585
Status: resolved
Priority: 0/
Queue: Encode

People
Owner: Nobody in particular
Requestors: ntyni [...] iki.fi
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 2.42
Fixed in: (no value)



Subject: enc2xs -C needlessly scans the current directory
As far as I can see, make_configlocal_pm() in bin/enc2xs could filter "." (the current directory) from @INC before running File::Find::find(). Any encoding files found under "." are skipped anyway in the wanted() function, so traversing the current directory may potentially scan the whole file system for no benefit. This would also mirror the find_e2x() function, which already filters out ".". Thanks for your work on Encode, -- Niko Tyni ntyni@iki.fi
From: jkeenan [...] cpan.org
On Fri Jan 07 14:12:37 2011, ntyni@iki.fi wrote: Show quoted text
> As far as I can see, make_configlocal_pm() in bin/enc2xs could filter > "." (the current directory) from @INC before running File::Find::find(). > Any encoding files found under "." are skipped anyway in the wanted() > function, so traversing the current directory may potentially scan the > whole file system for no benefit. >
Was also reported earlier in Perl's bug queue: https://rt.perl.org/rt3/Ticket/Display.html?id=50116
With RT#100656 fixed, this one is also effectively closed. Dan the Maintainer Thereof On Tue Jan 03 21:15:46 2012, JKEENAN wrote: Show quoted text
> On Fri Jan 07 14:12:37 2011, ntyni@iki.fi wrote:
> > As far as I can see, make_configlocal_pm() in bin/enc2xs could filter > > "." (the current directory) from @INC before running File::Find::find(). > > Any encoding files found under "." are skipped anyway in the wanted() > > function, so traversing the current directory may potentially scan the > > whole file system for no benefit. > >
> > Was also reported earlier in Perl's bug queue: > > https://rt.perl.org/rt3/Ticket/Display.html?id=50116